Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2876053002: Fixed NavigationItemImpl::GetDisplayTitleForURL for 'file://' URL. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30), ios-reviews+web_chromium.org, ios-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixed NavigationItemImpl::GetDisplayTitleForURL for 'file://' URL. Use full URL spec if it ends with / BUG=719982 Review-Url: https://codereview.chromium.org/2876053002 Cr-Commit-Position: refs/heads/master@{#471105} Committed: https://chromium.googlesource.com/chromium/src/+/6728ff6b6cff9e4d0b5f684d6d8eac068a2d5df6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -1 line) Patch
M ios/web/navigation/navigation_item_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_item_impl_unittest.mm View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-05-11 21:50:02 UTC) #4
kkhorimoto
lgtm
3 years, 7 months ago (2017-05-11 22:07:14 UTC) #7
Eugene But (OOO till 7-30)
Thanks for quick review!
3 years, 7 months ago (2017-05-11 22:40:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2876053002/1
3 years, 7 months ago (2017-05-11 22:42:23 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:07:15 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/6728ff6b6cff9e4d0b5f684d6d8e...

Powered by Google App Engine
This is Rietveld 408576698