ios/web/navigation/navigation_item_impl.mm - Issue 2876053002: Fixed NavigationItemImpl::GetDisplayTitleForURL for 'file://' URL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/web/navigation/navigation_item_impl.mm

Issue 2876053002: Fixed NavigationItemImpl::GetDisplayTitleForURL for 'file://' URL. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/web/navigation/navigation_item_impl.mm

diff --git a/ios/web/navigation/navigation_item_impl.mm b/ios/web/navigation/navigation_item_impl.mm

index 0b8aff9c295645f8c31b392fdb5cccc9f4d56d25..89273479169964979b58d49259a9403d35ba2e44 100644

--- a/ios/web/navigation/navigation_item_impl.mm

+++ b/ios/web/navigation/navigation_item_impl.mm

@@ -297,7 +297,7 @@ base::string16 NavigationItemImpl::GetDisplayTitleForURL(const GURL& url) {

// For file:// URLs use the filename as the title, not the full path.

if (url.SchemeIsFile()) {

base::string16::size_type slashpos = title.rfind('/');

- if (slashpos != base::string16::npos)

+ if (slashpos != base::string16::npos && slashpos != (title.size() - 1))

title = title.substr(slashpos + 1);

}

« no previous file with comments | « no previous file | ios/web/navigation/navigation_item_impl_unittest.mm » ('j') | no next file with comments »