Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2876041: Create _prebuild projects for targets with rules/actions (Closed)

Created:
10 years, 5 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Visibility:
Public.

Description

Effectively duplicates targets that contain rules/actions, therefore enabling correct dependency processing on windows. This patch mimics the changes for XCode.

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : regenerate guid #

Patch Set 4 : don't mess with copies #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
M pylib/gyp/generator/msvs.py View 1 3 2 chunks +33 lines, -1 line 1 comment Download

Messages

Total messages: 10 (0 generated)
bradn
LGTM
10 years, 5 months ago (2010-07-02 21:26:22 UTC) #1
jochen (gone - plz use gerrit)
the patch works on my local box. I submitted a tryjob to the win bot, ...
10 years, 5 months ago (2010-07-02 23:23:29 UTC) #2
M-A Ruel
btw it's awesome and simple, thanks! http://codereview.chromium.org/2876041/diff/11001/12001 File pylib/gyp/generator/msvs.py (right): http://codereview.chromium.org/2876041/diff/11001/12001#newcode1183 pylib/gyp/generator/msvs.py:1183: target_dicts[new_target] = deepcopy(target_dicts[qualified_target]) ...
10 years, 5 months ago (2010-07-03 14:04:55 UTC) #3
M-A Ruel
Another question; is this only needed when process_outputs_as_sources is defined? Is process_outputs_as_sources still useful at ...
10 years, 5 months ago (2010-07-03 14:07:09 UTC) #4
M-A Ruel
And lastly, a unit test? :D
10 years, 5 months ago (2010-07-03 14:07:24 UTC) #5
jochen (gone - plz use gerrit)
On 2010/07/03 14:04:55, Marc-Antoine Ruel wrote: > btw it's awesome and simple, thanks! > > ...
10 years, 5 months ago (2010-07-03 14:25:14 UTC) #6
jochen (gone - plz use gerrit)
On 2010/07/03 14:07:09, Marc-Antoine Ruel wrote: > Another question; is this only needed when process_outputs_as_sources ...
10 years, 5 months ago (2010-07-03 14:26:35 UTC) #7
jochen (gone - plz use gerrit)
On 2010/07/03 14:07:24, Marc-Antoine Ruel wrote: > And lastly, a unit test? :D in which ...
10 years, 5 months ago (2010-07-03 14:26:52 UTC) #8
M-A Ruel
On 2010/07/03 14:26:52, jochen wrote: > On 2010/07/03 14:07:24, Marc-Antoine Ruel wrote: > > And ...
10 years, 5 months ago (2010-07-03 14:38:55 UTC) #9
jochen (gone - plz use gerrit)
10 years, 5 months ago (2010-07-03 17:01:50 UTC) #10
On 2010/07/03 14:38:55, Marc-Antoine Ruel wrote:
> On 2010/07/03 14:26:52, jochen wrote:
> > On 2010/07/03 14:07:24, Marc-Antoine Ruel wrote:
> > > And lastly, a unit test? :D
> > 
> > in which directory should i put it?
> 
> I don't know. Others can help there.
> 
> On 2010/07/03 14:26:35, jochen wrote:
> > On 2010/07/03 14:07:09, Marc-Antoine Ruel wrote:
> > > Another question; is this only needed when process_outputs_as_sources is
> > > defined? Is process_outputs_as_sources still useful at all after this
> change,
> > > especially with the XCode change and the fact it's probably unnecessary
for
> > > make/SCons?
> > 
> > I don't know about make/scons. I think for xcode and msvs it would be enough
> to
> > only copy those targets where at least a rule or action has
> > process_outputs_as_sources set. However, since the xcode generator went down
> > this path I thought it would be good to do the same for msvs.
> 
> It's fine with me.

I've created http://codereview.chromium.org/2866042 to get trybot results in

Powered by Google App Engine
This is Rietveld 408576698