Create _prebuild projects for targets with rules/actions

pylib/gyp/generator/msvs.py

 #!/usr/bin/python
 
 # Copyright (c) 2009 Google Inc. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
+from copy import deepcopy
 import ntpath
+import os
 import posixpath
-import os
 import re
 import subprocess
 import sys
+import uuid
 
 import gyp.MSVSNew as MSVSNew
 import gyp.MSVSProject as MSVSProject
 import gyp.MSVSToolFile as MSVSToolFile
 import gyp.MSVSUserFile as MSVSUserFile
 import gyp.MSVSVersion as MSVSVersion
 import gyp.common
 
 
 # Regular expression for validating Visual Studio GUIDs.  If the GUID
@@ skipping 1131 matching lines @@
 
   # Prepare the set of configurations.
   configs = set()
   for qualified_target in target_list:
     build_file = gyp.common.BuildFile(qualified_target)
     spec = target_dicts[qualified_target]
     for config_name, c in spec['configurations'].iteritems():
       configs.add(_ConfigFullName(config_name, c))
   configs = list(configs)
 
+  # MSVS has some "issues" with checking dependencies for the "Compile
+  # sources" step with any source files/headers generated by actions/rules.
+  # To work around this, if a target is building anything directly (not
+  # type "none"), then a second target as used to run the GYP actions/rules
+  # and is made a dependency of this target.  This way the work is done
+  # before the dependency checks for what should be recompiled.
+  new_target_list = []
+  for qualified_target in target_list:
+    spec = target_dicts[qualified_target]
+    spec_actions = spec.get('actions', [])
+    spec_rules = spec.get('rules', [])
+    if spec['type'] != 'none' and (spec_actions or spec_rules):
+      [build_file, target, toolset] = gyp.common.ParseQualifiedTarget(
+          qualified_target)
+      new_target = "%s:%s_prebuilt" % (build_file, target)
+      if toolset:
+        new_target += "#%s" % (toolset)
+      target_dicts[new_target] = deepcopy(target_dicts[qualified_target])

[M-A Ruel, 2010/07/03 14:04:55]

I'd like it to check if new_target in target_dicts: first to detect inadvertent
override.

Also, shouldn't it copy include_dirs too? I guess all actions/rules don't use it
so it may be best to leave it out. I'm mostly wondering about idl processing
which have a concept of include dir, I don't know about the other rules/actions.

+      if spec.has_key('dependencies'):
+        target_dicts[new_target]['dependencies'].append(new_target)
+      else:
+        target_dicts[new_target]['dependencies'] = [new_target]
+      default_config = target_dicts[new_target]['configurations'][
+          target_dicts[new_target]['default_configuration']]
+      default_config['msvs_guid'] = str(uuid.uuid4()).upper()
+      new_target_list.append(new_target)
+    new_target_list.append(qualified_target)
+
+  target_list = new_target_list
+
   # Generate each project.
   projects = {}
   for qualified_target in target_list:
     build_file = gyp.common.BuildFile(qualified_target)
     spec = target_dicts[qualified_target]
     if spec['toolset'] != 'target':
       raise Exception(
           'Multiple toolsets not supported in msvs build (target %s)' %
           qualified_target)
     default_config = spec['configurations'][spec['default_configuration']]
@@ skipping 33 matching lines @@
     # Create folder hierarchy.
     root_entries = _GatherSolutionFolders(
         project_objs, flat=msvs_version.FlatSolution())
     # Create solution.
     sln = MSVSNew.MSVSSolution(sln_path,
                                entries=root_entries,
                                variants=configs,
                                websiteProperties=False,
                                version=msvs_version)
     sln.Write()