Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 2875923002: Don't show rotation change notification in tablet mode unless it's changed by user. (Closed)

Created:
3 years, 7 months ago by oshima
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't show rotation change notification in tablet mode unless it's changed by user. BUG=720190 TEST=covered by unit test Review-Url: https://codereview.chromium.org/2866423002 Cr-Commit-Position: refs/heads/master@{#470482} (cherry picked from commit 48358e269fbafbae5df07b4a82f0a7762f1ce19b) Review-Url: https://codereview.chromium.org/2875923002 . Cr-Commit-Position: refs/branch-heads/3071@{#511} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/7bcca463327ac6a7271475e93887b1da46270baa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -25 lines) Patch
M ash/system/screen_layout_observer.cc View 2 chunks +37 lines, -25 lines 0 comments Download
M ash/system/screen_layout_observer_unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
3 years, 7 months ago (2017-05-11 11:59:15 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bcca463327ac6a7271475e93887b1da46270baa.

Powered by Google App Engine
This is Rietveld 408576698