Don't show rotation change notification in tablet mode unless it's changed by user.

Don't show rotation change notification in tablet mode unless it's changed by user.

BUG=720190
TEST=covered by unit test

Review-Url: https://codereview.chromium.org/2866423002
Cr-Commit-Position: refs/heads/master@{#470482}
Committed: https://chromium.googlesource.com/chromium/src/+/48358e269fbafbae5df07b4a82f0a7762f1ce19b

[oshima, 2017-05-10 01:33:16]

Description was changed from

==========
Don't show rotation change notification in tablet mode unless it's changed by
user.

BUG=720190
TEST=covered by unit test
==========

to

==========
Don't show rotation change notification in tablet mode unless it's changed by
user.

BUG=720190
TEST=covered by unit test
==========

[oshima, 2017-05-10 01:33:16]

oshima@chromium.org changed reviewers:
+ afakhry@chromium.org

[oshima, 2017-05-10 04:25:50]

oshima@chromium.org changed reviewers:
+ skuhne@chromium.org
- afakhry@chromium.org

[Mr4D (OOO till 08-26), 2017-05-10 04:37:48]

lgtm

https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_ob...
File ash/system/screen_layout_observer.cc (right):

https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_ob...
ash/system/screen_layout_observer.cc:280: // b) if the device is in tablet mode,
and source is not user.
You might want to move this comment to line 275 and add a) the orientation does
not change.

[oshima, 2017-05-10 04:59:17]

Patchset #2 (id:20001) has been deleted

[oshima, 2017-05-10 04:59:23]

https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_ob...
File ash/system/screen_layout_observer.cc (right):

https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_ob...
ash/system/screen_layout_observer.cc:280: // b) if the device is in tablet mode,
and source is not user.
On 2017/05/10 04:37:48, Mr4D (IO delays) wrote:
> You might want to move this comment to line 275 and add a) the orientation
does
> not change.

Done

[oshima, 2017-05-10 04:59:26]

The CQ bit was checked by oshima@chromium.org

[oshima, 2017-05-10 04:59:26]

The patchset sent to the CQ was uploaded after l-g-t-m from skuhne@chromium.org
Link to the patchset: https://codereview.chromium.org/2866423002/#ps40001
(title: "Don't show rotation change notification in tablet mode unless it's
changed by user.")

[commit-bot: I haz the power, 2017-05-10 05:00:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 05:37:17]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494392366598300,
"parent_rev": "3bebec838b0f7523e0b134b25f84c106b992b2a0", "commit_rev":
"48358e269fbafbae5df07b4a82f0a7762f1ce19b"}

[commit-bot: I haz the power, 2017-05-10 05:37:27]

Description was changed from

==========
Don't show rotation change notification in tablet mode unless it's changed by
user.

BUG=720190
TEST=covered by unit test
==========

to

==========
Don't show rotation change notification in tablet mode unless it's changed by
user.

BUG=720190
TEST=covered by unit test

Review-Url: https://codereview.chromium.org/2866423002
Cr-Commit-Position: refs/heads/master@{#470482}
Committed:
https://chromium.googlesource.com/chromium/src/+/48358e269fbafbae5df07b4a82f0...
==========

[commit-bot: I haz the power, 2017-05-10 05:37:28]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/48358e269fbafbae5df07b4a82f0...