Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2866423002: Don't show rotation change notification in tablet mode unless it's changed by user. (Closed)

Created:
3 years, 7 months ago by oshima
Modified:
3 years, 7 months ago
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't show rotation change notification in tablet mode unless it's changed by user. BUG=720190 TEST=covered by unit test Review-Url: https://codereview.chromium.org/2866423002 Cr-Commit-Position: refs/heads/master@{#470482} Committed: https://chromium.googlesource.com/chromium/src/+/48358e269fbafbae5df07b4a82f0a7762f1ce19b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Don't show rotation change notification in tablet mode unless it's changed by user. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -25 lines) Patch
M ash/system/screen_layout_observer.cc View 1 2 chunks +37 lines, -25 lines 0 comments Download
M ash/system/screen_layout_observer_unittest.cc View 2 chunks +36 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
oshima
3 years, 7 months ago (2017-05-10 04:26:14 UTC) #4
Mr4D (OOO till 08-26)
lgtm https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_observer.cc File ash/system/screen_layout_observer.cc (right): https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_observer.cc#newcode280 ash/system/screen_layout_observer.cc:280: // b) if the device is in tablet ...
3 years, 7 months ago (2017-05-10 04:37:48 UTC) #5
oshima
https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_observer.cc File ash/system/screen_layout_observer.cc (right): https://codereview.chromium.org/2866423002/diff/1/ash/system/screen_layout_observer.cc#newcode280 ash/system/screen_layout_observer.cc:280: // b) if the device is in tablet mode, ...
3 years, 7 months ago (2017-05-10 04:59:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2866423002/40001
3 years, 7 months ago (2017-05-10 05:00:19 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-05-10 05:37:28 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/48358e269fbafbae5df07b4a82f0...

Powered by Google App Engine
This is Rietveld 408576698