Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 2875673004: [Mac] Fullscreen Toolbar Fixes (Closed)

Created:
3 years, 7 months ago by spqchan
Modified:
3 years, 7 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Fullscreen Toolbar Fixes - Increased the mouse threshold to hide the toolbar -The toolbar will now hide when the mouse is over 50px below it - In FullscreenMenubarTracker, the toolbar layout and menubarFraction needs to be updated before the tracker attempt to animate the toolbar out. BUG=692275 Review-Url: https://codereview.chromium.org/2875673004 Cr-Commit-Position: refs/heads/master@{#471016} Committed: https://chromium.googlesource.com/chromium/src/+/50aafec7a5ed2822f6dd50acfd2c2c4a79e01fce

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (10 generated)
spqchan
PTAL
3 years, 7 months ago (2017-05-11 17:28:45 UTC) #8
Avi (use Gerrit)
lgtm
3 years, 7 months ago (2017-05-11 18:19:23 UTC) #9
spqchan
On 2017/05/11 18:19:23, Avi (ping after 24h) wrote: > lgtm thanks!
3 years, 7 months ago (2017-05-11 18:19:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875673004/1
3 years, 7 months ago (2017-05-11 18:21:18 UTC) #12
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 18:36:54 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/50aafec7a5ed2822f6dd50acfd2c...

Powered by Google App Engine
This is Rietveld 408576698