Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(542)

Unified Diff: chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm

Issue 2875673004: [Mac] Fullscreen Toolbar Fixes (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
diff --git a/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm b/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
index b9c1486aaee2d39354f63d46c0b2479666157bc5..f7c326ea2ae5327a40843127ea4fd7765f9c5ce3 100644
--- a/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
+++ b/chrome/browser/ui/cocoa/fullscreen/fullscreen_menubar_tracker.mm
@@ -138,6 +138,9 @@ OSStatus MenuBarRevealHandler(EventHandlerCallRef handler,
else if (progress > menubarFraction_)
state_ = FullscreenMenubarState::SHOWING;
+ menubarFraction_ = progress;
+ [owner_ updateToolbarLayout];
+
// In 10.12. the toolbar to be janky since the UI doesn't update until the
// menubar finished revealing itself. To smooth things out, animate the
// toolbar in/out by locking/releasing its visibility instead of relying on
@@ -153,9 +156,6 @@ OSStatus MenuBarRevealHandler(EventHandlerCallRef handler,
withAnimation:YES];
}
}
-
- menubarFraction_ = progress;
- [owner_ updateToolbarLayout];
}
- (BOOL)isMouseOnScreen {
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_mouse_tracker.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698