Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Issue 287563002: Added Blink-side support for EXT_blend_minmax WebGL extension (Closed)

Created:
6 years, 7 months ago by bajones
Modified:
6 years, 7 months ago
CC:
blink-reviews, arv+blink, blink-reviews-html_chromium.org, abarth-chromium, dglazkov+blink, Rik, blink-reviews-bindings_chromium.org, Inactive, aandrey+blink_chromium.org, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Added Blink-side support for EXT_blend_minmax WebGL extension BUG=344451 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173937

Patch Set 1 #

Patch Set 2 : Made sure validation set the right glError #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -7 lines) Patch
M Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
A + Source/core/html/canvas/EXTBlendMinMax.h View 2 chunks +7 lines, -7 lines 0 comments Download
A Source/core/html/canvas/EXTBlendMinMax.cpp View 1 chunk +42 lines, -0 lines 0 comments Download
A Source/core/html/canvas/EXTBlendMinMax.idl View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLExtensionName.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
bajones
While triaging some WebGL tickets I realized that this extension would be extremely simple to ...
6 years, 7 months ago (2014-05-12 23:32:18 UTC) #1
bajones
FYI, Chrome-side is here: https://codereview.chromium.org/286553002/
6 years, 7 months ago (2014-05-12 23:34:55 UTC) #2
Zhenyao Mo
On 2014/05/12 23:34:55, bajones wrote: > FYI, Chrome-side is here: https://codereview.chromium.org/286553002/ LGTM
6 years, 7 months ago (2014-05-12 23:40:40 UTC) #3
haraken
bindings/ LGTM.
6 years, 7 months ago (2014-05-12 23:45:48 UTC) #4
Ken Russell (switch to Gerrit)
lgtm
6 years, 7 months ago (2014-05-12 23:50:50 UTC) #5
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 7 months ago (2014-05-12 23:55:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/287563002/1
6 years, 7 months ago (2014-05-12 23:55:26 UTC) #7
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 01:18:49 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-13 01:57:14 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/7038)
6 years, 7 months ago (2014-05-13 01:57:14 UTC) #10
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 7 months ago (2014-05-13 05:45:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/287563002/20001
6 years, 7 months ago (2014-05-13 05:45:42 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-13 07:00:51 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 07:52:45 UTC) #14
Message was sent while issue was closed.
Change committed as 173937

Powered by Google App Engine
This is Rietveld 408576698