Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 2875603002: DCHECK FrameView in LayoutSelection::SetSelection() (Closed)

Created:
3 years, 7 months ago by yoichio
Modified:
3 years, 7 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

DCHECK FrameView in LayoutSelection::SetSelection() We early return when FrameView is not available, but it should not happen. BUG=708453 Review-Url: https://codereview.chromium.org/2875603002 Cr-Commit-Position: refs/heads/master@{#470835} Committed: https://chromium.googlesource.com/chromium/src/+/662c7984fa505100839315658fa70320ddf58a11

Patch Set 1 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yoichio
3 years, 7 months ago (2017-05-11 01:41:50 UTC) #8
yosin_UTC9
lgtm
3 years, 7 months ago (2017-05-11 03:51:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875603002/20001
3 years, 7 months ago (2017-05-11 03:52:49 UTC) #11
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 06:03:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/662c7984fa505100839315658fa7...

Powered by Google App Engine
This is Rietveld 408576698