Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: third_party/WebKit/Source/core/editing/LayoutSelection.cpp

Issue 2875603002: DCHECK FrameView in LayoutSelection::SetSelection() (Closed)
Patch Set: update Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/LayoutSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/LayoutSelection.cpp b/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
index cd5cc26b30d141b990834a5611edc212cd91e2f3..914c8f64776ab113461c172613f07e1192af82b1 100644
--- a/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/LayoutSelection.cpp
@@ -148,6 +148,8 @@ void LayoutSelection::SetSelection(
selection_end_ == end && selection_end_pos_ == end_pos)
return;
+ DCHECK(frame_selection_->GetDocument().GetLayoutView()->GetFrameView());
+
// Record the old selected objects. These will be used later when we compare
// against the new selected objects.
int old_start_pos = selection_start_pos_;
@@ -256,10 +258,6 @@ void LayoutSelection::SetSelection(
exploring_backwards);
}
- // TODO(yoichio): DCHECK(frame_selection_->,,,->GetFrameView());
- if (!frame_selection_->GetDocument().GetLayoutView()->GetFrameView())
- return;
-
// Have any of the old selected objects changed compared to the new selection?
for (SelectedObjectMap::iterator i = old_selected_objects.begin();
i != old_objects_end; ++i) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698