Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2875383002: Upstream service worker `postMessage` tests to WPT (Closed)

Created:
3 years, 7 months ago by mike3
Modified:
3 years, 7 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, blink-reviews-w3ctests_chromium.org, nhiroki, kinuko+serviceworker, blink-reviews, horo+watch_chromium.org, falken+watch_chromium.org, tzik
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream service worker `postMessage` tests to WPT **postmessage-msgport-to-client** This test exists in both WPT and the Chromium project tree. Although the two implementations assert the same behavior, the Chromium version is preferable for a number of reasons: - It uses the `promise_test` function and expresses the test body in terms of promises, resulting in improved test readability. - It extends the "message" event lifetime via `ExtendableEvent#waitUntil`, discouraging unexpected worker termination. Update the upstream version of the test with these improvements. In addition, remove the dynamically-generated iframe at the test's conclusion. Remove the Chromium-specific version of the test. **postmessage-to-client** This test exists in both WPT and the Chromium project tree. Although the two implementations assert the same behavior, the Chromium version is preferable for a number of reasons: - It uses the `promise_test` function and expresses the test body in terms of promises, resulting in improved test readability. - It extends the "message" event lifetime via `ExtendableEvent#waitUntil`, discouraging unexpected worker termination. Retain the additional assertions present in the upstream version (i.e. those for the `bubbles` and `cancelable` attributes of the event object). Update the upstream version of the test with these improvements. In addition, remove the dynamically-generated iframe at the test's conclusion. Remove the Chromium-specific version of the test. **postmessage** This test exists in both WPT and the Chromium project tree. Although the two implementations assert the same behavior, the Chromium version is preferable for a number of reasons: - It includes additional tests concerning the transference of ArrayBuffer instances between clients and worker - It uses the `promise_test` function and expresses the test body in terms of promises, resulting in improved test readability. Update the upstream version of the test with these improvements. Remove the Chromium-specific version of the test. BUG=688116 R=falken@chromium.org Review-Url: https://codereview.chromium.org/2875383002 Cr-Commit-Position: refs/heads/master@{#471940} Committed: https://chromium.googlesource.com/chromium/src/+/f4c4a4de426ccab70896c80c48e58b770420c008

Patch Set 1 #

Total comments: 10

Patch Set 2 : Incorporate review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -444 lines) Patch
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html View 1 1 chunk +34 lines, -42 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-to-client.https.html View 1 1 chunk +42 lines, -40 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage.https.html View 1 1 chunk +125 lines, -46 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js View 1 chunk +7 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-to-client-worker.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-transferables-worker.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage.html View 1 1 chunk +0 lines, -141 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-msgport-to-client.html View 1 chunk +0 lines, -44 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-to-client.html View 1 chunk +0 lines, -50 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-msgport-to-client-worker.js View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-to-client-worker.js View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-transferables-worker.js View 1 chunk +0 lines, -24 lines 0 comments Download
D third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-worker.js View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
mike3
Hey Matt, welcome back! Mind taking a look at this patch?
3 years, 7 months ago (2017-05-12 16:58:06 UTC) #1
falken
lgtm https://codereview.chromium.org/2875383002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html (right): https://codereview.chromium.org/2875383002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html#newcode2 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html:2: <title>Service Worker: postMessage to Client</title> postMessage via MessagePort ...
3 years, 7 months ago (2017-05-15 05:10:33 UTC) #2
mike3
Thanks, Matt! https://codereview.chromium.org/2875383002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html File third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html (right): https://codereview.chromium.org/2875383002/diff/1/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html#newcode2 third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/postmessage-msgport-to-client.https.html:2: <title>Service Worker: postMessage to Client</title> On 2017/05/15 ...
3 years, 7 months ago (2017-05-15 20:07:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875383002/1
3 years, 7 months ago (2017-05-15 20:08:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875383002/20001
3 years, 7 months ago (2017-05-15 20:20:13 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-15 23:05:20 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f4c4a4de426ccab70896c80c48e5...

Powered by Google App Engine
This is Rietveld 408576698