Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js

Issue 2875383002: Upstream service worker `postMessage` tests to WPT (Closed)
Patch Set: Incorporate review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js
diff --git a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js
index 3475321f4a6813e808bdc969d86240b62cafd12d..7af935f4f8fc01756980e46dcce5018ddc620e67 100644
--- a/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js
+++ b/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/resources/postmessage-msgport-to-client-worker.js
@@ -1,20 +1,19 @@
self.onmessage = function(e) {
- self.clients.matchAll().then(function(clients) {
+ e.waitUntil(self.clients.matchAll().then(function(clients) {
clients.forEach(function(client) {
var messageChannel = new MessageChannel();
messageChannel.port1.onmessage =
- onMessageViaMessagePort.bind(null, client);
- client.postMessage({port: messageChannel.port2},
- [messageChannel.port2]);
+ onMessageViaMessagePort.bind(null, messageChannel.port1);
+ client.postMessage(undefined, [messageChannel.port2]);
});
- });
+ }));
};
-function onMessageViaMessagePort(client, e) {
+function onMessageViaMessagePort(port, e) {
var message = e.data;
if ('value' in message) {
- client.postMessage({ack: 'Acking value: ' + message.value});
+ port.postMessage({ack: 'Acking value: ' + message.value});
} else if ('done' in message) {
- client.postMessage({done: true});
+ port.postMessage({done: true});
}
}

Powered by Google App Engine
This is Rietveld 408576698