Add migration to WebAssembly information to PNaCl / NaCl docs.

Add migration to WebAssembly information to PNaCl / NaCl docs.

BUG=None
R=laforge@chromium.org,binji@chromium.org,sbc@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2875303003
Cr-Commit-Position: refs/heads/master@{#475662}
Committed: https://chromium.googlesource.com/chromium/src/+/720c608e5299767a7a2bec8f6fb298fc3c3e9175

[bradnelson, 2017-05-13 00:26:20]

PTAL

Direct your attention mainly to migration.rst + deprecation.inc

[Ken Rockot(use gerrit already), 2017-05-13 00:27:43]

extension lgtm with nit

https://codereview.chromium.org/2875303003/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/json/chrome_sidenav.json (right):

https://codereview.chromium.org/2875303003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/json/chrome_sidenav.json:725: "title":
"Migration Guide",
nit: Should this maybe be "WebAssembly Migration Guide"?

[bradnelson, 2017-05-13 00:35:19]

PTAL

https://codereview.chromium.org/2875303003/diff/1/chrome/common/extensions/do...
File chrome/common/extensions/docs/templates/json/chrome_sidenav.json (right):

https://codereview.chromium.org/2875303003/diff/1/chrome/common/extensions/do...
chrome/common/extensions/docs/templates/json/chrome_sidenav.json:725: "title":
"Migration Guide",
On 2017/05/13 00:27:43, Ken Rockot wrote:
> nit: Should this maybe be "WebAssembly Migration Guide"?

Done.

[binji, 2017-05-15 18:23:45]

lgtm

lgtm, w/ some comments

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
File native_client_sdk/src/doc/migration/irt.html (right):

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/irt.html:41: <td style="font-size: 11px;
padding: 5px;">Simulate with Atomics.wait </td>
Does it make sense to point to the JS API if we're suggesting using WebAssembly?

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/irt.html:76: <td style="font-size: 11px;
padding: 5px;">To relevant to Wasm, implementation detail. </td>
s/To/Not/ here and elsewhere

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
File native_client_sdk/src/doc/migration/public.html (right):

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:510: <td bgcolor="#ffcccc"
style="font-size: 11px; padding: 5px;">GAP - PPAPI exposes a timestamp value,
but the JS API doesn't provide this (though it is speced).</td>
specced or spec'd?

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:653: <td style="font-size: 11px;
padding: 5px;">&lt;Canvas&gt;.width = w; &lt;Canvas&gt;.height = h; </td>
Why wrapped with &lt;&gt;?

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:1446: <td style="font-size:
11px; padding: 5px;">TODO(bradnelson): more detail </td>
Is this meant to be included?

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:1473: <td style="font-size:
11px; padding: 5px;">Unity has specifically raised a desire to either be able to
hint in this fashion, or preferrably the ability to intercept and display IME
events / output inline inside a canvas. </td>
Is this meant to be included?

[seththompson, 2017-05-17 22:07:04]

On 2017/05/15 at 18:23:45, binji wrote:
> lgtm
> 
> lgtm, w/ some comments
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> File native_client_sdk/src/doc/migration/irt.html (right):
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> native_client_sdk/src/doc/migration/irt.html:41: <td style="font-size: 11px;
padding: 5px;">Simulate with Atomics.wait </td>
> Does it make sense to point to the JS API if we're suggesting using
WebAssembly?
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> native_client_sdk/src/doc/migration/irt.html:76: <td style="font-size: 11px;
padding: 5px;">To relevant to Wasm, implementation detail. </td>
> s/To/Not/ here and elsewhere
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> File native_client_sdk/src/doc/migration/public.html (right):
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> native_client_sdk/src/doc/migration/public.html:510: <td bgcolor="#ffcccc"
style="font-size: 11px; padding: 5px;">GAP - PPAPI exposes a timestamp value,
but the JS API doesn't provide this (though it is speced).</td>
> specced or spec'd?
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> native_client_sdk/src/doc/migration/public.html:653: <td style="font-size:
11px; padding: 5px;">&lt;Canvas&gt;.width = w; &lt;Canvas&gt;.height = h; </td>
> Why wrapped with &lt;&gt;?
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> native_client_sdk/src/doc/migration/public.html:1446: <td style="font-size:
11px; padding: 5px;">TODO(bradnelson): more detail </td>
> Is this meant to be included?
> 
>
https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
> native_client_sdk/src/doc/migration/public.html:1473: <td style="font-size:
11px; padding: 5px;">Unity has specifically raised a desire to either be able to
hint in this fashion, or preferrably the ability to intercept and display IME
events / output inline inside a canvas. </td>
> Is this meant to be included?

[seththompson, 2017-05-17 22:08:14]

seththompson@chromium.org changed reviewers:
+ seththompson@chromium.org

[seththompson, 2017-05-17 22:08:16]

Oops, forgot to include drafts:

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
File native_client_sdk/src/doc/migration/index.rst (right):

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/index.rst:14: As a result, in the near
future, PNaCl will no longer be supported in Chrome.
I think we should be sure to mention this is an "upcoming deprecation" and
mention the specific date that we announce in the post (Q1 2018).

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/index.rst:17: We appreciate the investment
you've made bringing native code to the Web
I think this sentence is a bit jarring: it starts out with "we appreciate the
investment *you've* made"... and then ends with an implicit "[we] have now
refocused..."

Perhaps we can just reuse the paragraph from the blog post?

"Given the momentum of cross-browser WebAssembly support, we plan to focus our
native code efforts on WebAssembly going forward and plan to remove support for
PNaCl in Q1 2018 (except for Chrome Apps). We believe that the vibrant ecosystem
around WebAssembly makes it a better fit for new and existing high-performance
web apps and that usage of PNaCl is sufficiently low to warrant deprecation."
"

[bradn, 2017-05-18 05:39:23]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2017-05-18 05:39:25]

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
File native_client_sdk/src/doc/migration/index.rst (right):

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/index.rst:14: As a result, in the near
future, PNaCl will no longer be supported in Chrome.
On 2017/05/17 22:08:16, seththompson wrote:
> I think we should be sure to mention this is an "upcoming deprecation" and
> mention the specific date that we announce in the post (Q1 2018).

Done by way of using the one below and reordering.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/index.rst:17: We appreciate the investment
you've made bringing native code to the Web
On 2017/05/17 22:08:16, seththompson wrote:
> I think this sentence is a bit jarring: it starts out with "we appreciate the
> investment *you've* made"... and then ends with an implicit "[we] have now
> refocused..."
> 
> Perhaps we can just reuse the paragraph from the blog post?
> 
> "Given the momentum of cross-browser WebAssembly support, we plan to focus our
> native code efforts on WebAssembly going forward and plan to remove support
for
> PNaCl in Q1 2018 (except for Chrome Apps). We believe that the vibrant
ecosystem
> around WebAssembly makes it a better fit for new and existing high-performance
> web apps and that usage of PNaCl is sufficiently low to warrant deprecation."
> "

Done.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
File native_client_sdk/src/doc/migration/irt.html (right):

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/irt.html:41: <td style="font-size: 11px;
padding: 5px;">Simulate with Atomics.wait </td>
On 2017/05/15 18:23:44, binji wrote:
> Does it make sense to point to the JS API if we're suggesting using
WebAssembly?

Added comment.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/irt.html:76: <td style="font-size: 11px;
padding: 5px;">To relevant to Wasm, implementation detail. </td>
On 2017/05/15 18:23:44, binji wrote:
> s/To/Not/ here and elsewhere

Done.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
File native_client_sdk/src/doc/migration/public.html (right):

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:510: <td bgcolor="#ffcccc"
style="font-size: 11px; padding: 5px;">GAP - PPAPI exposes a timestamp value,
but the JS API doesn't provide this (though it is speced).</td>
On 2017/05/15 18:23:44, binji wrote:
> specced or spec'd?

Done.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:653: <td style="font-size: 11px;
padding: 5px;">&lt;Canvas&gt;.width = w; &lt;Canvas&gt;.height = h; </td>
On 2017/05/15 18:23:44, binji wrote:
> Why wrapped with &lt;&gt;?

Made consistent.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:1446: <td style="font-size:
11px; padding: 5px;">TODO(bradnelson): more detail </td>
On 2017/05/15 18:23:44, binji wrote:
> Is this meant to be included?

Dropped.

https://codereview.chromium.org/2875303003/diff/20001/native_client_sdk/src/d...
native_client_sdk/src/doc/migration/public.html:1473: <td style="font-size:
11px; padding: 5px;">Unity has specifically raised a desire to either be able to
hint in this fashion, or preferrably the ability to intercept and display IME
events / output inline inside a canvas. </td>
On 2017/05/15 18:23:44, binji wrote:
> Is this meant to be included?

Changed.

[bradnelson, 2017-05-30 19:23:03]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2017-05-30 19:23:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
binji@chromium.org
Link to the patchset: https://codereview.chromium.org/2875303003/#ps30001
(title: "fix")

[commit-bot: I haz the power, 2017-05-30 19:23:46]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 19:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-30 19:31:09]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[bradnelson, 2017-05-30 20:30:25]

The CQ bit was checked by bradnelson@chromium.org

[bradnelson, 2017-05-30 20:30:27]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
binji@chromium.org
Link to the patchset: https://codereview.chromium.org/2875303003/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-05-30 20:30:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-30 20:51:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1496176225826280,
"parent_rev": "aa9f49f72f1f2cb39fa3f4d13d6b2382d56d9fa7", "commit_rev":
"720c608e5299767a7a2bec8f6fb298fc3c3e9175"}

[commit-bot: I haz the power, 2017-05-30 20:51:55]

Description was changed from

==========
Add migration to WebAssembly information to PNaCl / NaCl docs.

BUG=None
R=laforge@chromium.org,binji@chromium.org,sbc@chromium.org,rockot@chromium.org
==========

to

==========
Add migration to WebAssembly information to PNaCl / NaCl docs.

BUG=None
R=laforge@chromium.org,binji@chromium.org,sbc@chromium.org,rockot@chromium.org

Review-Url: https://codereview.chromium.org/2875303003
Cr-Commit-Position: refs/heads/master@{#475662}
Committed:
https://chromium.googlesource.com/chromium/src/+/720c608e5299767a7a2bec8f6fb2...
==========

[commit-bot: I haz the power, 2017-05-30 20:51:57]

Committed patchset #5 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/720c608e5299767a7a2bec8f6fb2...