Support for transfer navigations in data use ascriber

Support for transfer navigations in data use ascriber

Before the navigation commits, old mainframe could be reused in ReadyToCommit. After that
new mainframe may be created and the navigation transfers from the old mainframe to the new.
To handle this case, ascribing the datause should happen after navigation commits at
DidFinishNavigation. The global request ID of the navigation should be copied from
ReadyToCommit to DidFinishNavigation. This is only applicable for non PlzNavigate.

BUG=718612
Review-Url: https://codereview.chromium.org/2875263003
Cr-Commit-Position: refs/heads/master@{#473837}
Committed: https://chromium.googlesource.com/chromium/src/+/54819c15bc373470597bb574895816174e633c72

[rajendrant, 2017-05-12 16:18:17]

rajendrant@google.com changed reviewers:
+ rajendrant@google.com, ryansturm@chromium.org

[rajendrant, 2017-05-12 16:18:18]

ptal

[RyanSturm, 2017-05-17 16:14:49]

lgtm % comment

https://codereview.chromium.org/2875263003/diff/1/chrome/browser/data_use_mea...
File chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
(right):

https://codereview.chromium.org/2875263003/diff/1/chrome/browser/data_use_mea...
chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc:168:
!navigation_handle->HasCommitted() || navigation_handle->IsSameDocument())
You are checking IsSameDocument in two places Probably remove it here so
downloads are added into the correct entry.

[Raj, 2017-05-18 06:25:05]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 06:25:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 07:00:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 07:00:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Raj, 2017-05-18 07:26:51]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-18 07:27:26]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rajendrant, 2017-05-18 07:48:18]

The CQ bit was unchecked by rajendrant@google.com

[rajendrant, 2017-05-18 07:48:32]

The CQ bit was checked by rajendrant@google.com

[rajendrant, 2017-05-18 07:48:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2875263003/#ps80001
(title: "fix tests")

[commit-bot: I haz the power, 2017-05-18 07:49:06]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 09:15:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 09:15:50]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[RyanSturm, 2017-05-18 19:01:00]

The CQ bit was checked by ryansturm@chromium.org

[commit-bot: I haz the power, 2017-05-18 19:02:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-18 20:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-18 20:12:47]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[rajendrant, 2017-05-23 07:48:38]

The CQ bit was checked by rajendrant@google.com

[rajendrant, 2017-05-23 07:48:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2875263003/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2017-05-23 07:48:53]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-23 08:34:16]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1495525718515820,
"parent_rev": "3363d5074a1b4579a8ccc9ddd1e52f99489719fe", "commit_rev":
"54819c15bc373470597bb574895816174e633c72"}

[commit-bot: I haz the power, 2017-05-23 08:34:34]

Description was changed from

==========
Support for transfer navigations in data use ascriber

Before the navigation commits, old mainframe could be reused in ReadyToCommit.
After that
new mainframe may be created and the navigation transfers from the old mainframe
to the new.
To handle this case, ascribing the datause should happen after navigation
commits at
DidFinishNavigation. The global request ID of the navigation should be copied
from
ReadyToCommit to DidFinishNavigation. This is only applicable for non
PlzNavigate.

BUG=718612
==========

to

==========
Support for transfer navigations in data use ascriber

Before the navigation commits, old mainframe could be reused in ReadyToCommit.
After that
new mainframe may be created and the navigation transfers from the old mainframe
to the new.
To handle this case, ascribing the datause should happen after navigation
commits at
DidFinishNavigation. The global request ID of the navigation should be copied
from
ReadyToCommit to DidFinishNavigation. This is only applicable for non
PlzNavigate.

BUG=718612

Review-Url: https://codereview.chromium.org/2875263003
Cr-Commit-Position: refs/heads/master@{#473837}
Committed:
https://chromium.googlesource.com/chromium/src/+/54819c15bc373470597bb5748958...
==========

[commit-bot: I haz the power, 2017-05-23 08:34:35]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/54819c15bc373470597bb5748958...