Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(921)

Unified Diff: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc

Issue 2875263003: Support for transfer navigations in data use ascriber (Closed)
Patch Set: rebased Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
diff --git a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
index 9f305a828a84c9377ceb2efee00c084a8072fd17..c4699867df128a30c27c8f0c38b03267378ad784 100644
--- a/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
+++ b/chrome/browser/data_use_measurement/chrome_data_use_ascriber_service.cc
@@ -154,21 +154,17 @@ void ChromeDataUseAscriberService::ReadyToCommitNavigation(
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
base::BindOnce(&ChromeDataUseAscriber::ReadyToCommitMainFrameNavigation,
- base::Unretained(ascriber_), navigation_handle->GetURL(),
+ base::Unretained(ascriber_),
navigation_handle->GetGlobalRequestID(),
web_contents->GetRenderProcessHost()->GetID(),
- web_contents->GetMainFrame()->GetRoutingID(),
- !navigation_handle->HasCommitted() ||
- navigation_handle->IsSameDocument(),
- navigation_handle));
+ web_contents->GetMainFrame()->GetRoutingID()));
}
void ChromeDataUseAscriberService::DidFinishNavigation(
content::NavigationHandle* navigation_handle) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
- if (!navigation_handle->IsInMainFrame() ||
- !navigation_handle->HasCommitted() || navigation_handle->IsSameDocument())
+ if (!navigation_handle->IsInMainFrame() || !navigation_handle->HasCommitted())
return;
if (!ascriber_)
@@ -181,6 +177,8 @@ void ChromeDataUseAscriberService::DidFinishNavigation(
base::Unretained(ascriber_),
web_contents->GetRenderProcessHost()->GetID(),
web_contents->GetMainFrame()->GetRoutingID(),
+ navigation_handle->GetURL(),
+ navigation_handle->IsSameDocument(),
navigation_handle->GetPageTransition()));
}

Powered by Google App Engine
This is Rietveld 408576698