Added web::GetCommittedItemWithUniqueID function.

Added web::GetCommittedItem(Index)WithUniqueID functions.

Updated SSLStatusUpdated to use GetCommittedItemWithUniqueID and
CRWWebController to use GetCommittedItemIndexWithUniqueID.

GetCommittedItemWithUniqueID will also be used in the future CL for
doing NavigationItem lookup by ID.

BUG=None

Review-Url: https://codereview.chromium.org/2875153003
Cr-Commit-Position: refs/heads/master@{#474667}
Committed: https://chromium.googlesource.com/chromium/src/+/16f939d96566d7f80278cb27287a62d973aa7475

[Eugene But (OOO till 7-30), 2017-05-12 01:42:07]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 01:42:47]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 03:30:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 03:30:11]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-05-15 16:43:10]

Description was changed from

==========
Added web::GetCommittedItemWithUniqueID function.

Updated SSLStatusUpdated to use this new function.
GetCommittedItemWithUniqueID will also be used in the future CLs for
doing NavigationItem lookup by ID.

BUG=None
==========

to

==========
Added web::GetCommittedItemWithUniqueID function.

Updated SSLStatusUpdated to use this new function.
GetCommittedItemWithUniqueID will also be used in the future CLs for
doing NavigationItem lookup by ID.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-05-25 00:57:27]

Description was changed from

==========
Added web::GetCommittedItemWithUniqueID function.

Updated SSLStatusUpdated to use this new function.
GetCommittedItemWithUniqueID will also be used in the future CLs for
doing NavigationItem lookup by ID.

BUG=None
==========

to

==========
Added web::GetCommittedItem(Index)WithUniqueID functions.

Updated SSLStatusUpdated to use GetCommittedItemWithUniqueID and
CRWWebController to use GetCommittedItemIndexWithUniqueID.

GetCommittedItemWithUniqueID will also be used in the future CL for
doing NavigationItem lookup by ID.

BUG=None
==========

[Eugene But (OOO till 7-30), 2017-05-25 01:00:12]

eugenebut@chromium.org changed reviewers:
+ kkhorimoto@chromium.org

[kkhorimoto, 2017-05-25 02:19:38]

The code looks good, I just have a general question.  Why are we keeping these
utility functions private?  They're using all public APIs, and it might be
useful to other embedders.  For that matter, why do we not include the unique ID
in the NavigationContext upstream interface?  NavigationManager::GetUniqueID()
is a public function, but it seems we're trying to prevent its usage by keeping
all of this logic downstream.

[Eugene But (OOO till 7-30), 2017-05-25 02:48:58]

On 2017/05/25 02:19:38, kkhorimoto_ wrote:
> The code looks good, I just have a general question.  Why are we keeping these
> utility functions private?  They're using all public APIs, and it might be
> useful to other embedders.  For that matter, why do we not include the unique
ID
> in the NavigationContext upstream interface?  NavigationManager::GetUniqueID()
> is a public function, but it seems we're trying to prevent its usage by
keeping
> all of this logic downstream.
It is always better to have fewer public APIs. More APIs - more complexity, more
integration tests to write and more things to learn.
If someone will ever need these functions, we can always add them to navigation
manager and navigation context.

[kkhorimoto, 2017-05-25 03:06:24]

makes sense.  lgtm

[Eugene But (OOO till 7-30), 2017-05-25 14:33:10]

Thanks!

[Eugene But (OOO till 7-30), 2017-05-25 14:33:14]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-05-25 14:33:32]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-25 16:07:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1495722794288990,
"parent_rev": "3678003e29b6dc924fd06e4f352e419e6321a73c", "commit_rev":
"16f939d96566d7f80278cb27287a62d973aa7475"}

[commit-bot: I haz the power, 2017-05-25 16:07:28]

Description was changed from

==========
Added web::GetCommittedItem(Index)WithUniqueID functions.

Updated SSLStatusUpdated to use GetCommittedItemWithUniqueID and
CRWWebController to use GetCommittedItemIndexWithUniqueID.

GetCommittedItemWithUniqueID will also be used in the future CL for
doing NavigationItem lookup by ID.

BUG=None
==========

to

==========
Added web::GetCommittedItem(Index)WithUniqueID functions.

Updated SSLStatusUpdated to use GetCommittedItemWithUniqueID and
CRWWebController to use GetCommittedItemIndexWithUniqueID.

GetCommittedItemWithUniqueID will also be used in the future CL for
doing NavigationItem lookup by ID.

BUG=None

Review-Url: https://codereview.chromium.org/2875153003
Cr-Commit-Position: refs/heads/master@{#474667}
Committed:
https://chromium.googlesource.com/chromium/src/+/16f939d96566d7f80278cb27287a...
==========

[commit-bot: I haz the power, 2017-05-25 16:07:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/16f939d96566d7f80278cb27287a...