Roll googletest to 1.8.0+.

Roll googletest to 1.8.0+.

BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init

Review-Url: https://codereview.chromium.org/2875143003
Cr-Commit-Position: refs/heads/master@{#471303}
Committed: https://chromium.googlesource.com/chromium/src/+/591b221c6a14bf529923e69df1ad93535ac5a626

[pwnall, 2017-05-12 01:12:32]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 01:13:24]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-05-12 01:16:27]

pwnall@chromium.org changed reviewers:
+ agl@chromium.org, thakis@chromium.org

[pwnall, 2017-05-12 01:16:28]

agl@: Can you please review the changes to 
net/socket/sequenced_socket_data_unittest.cc?

thakis@: Can you please review everything else?

[Nico, 2017-05-12 01:21:12]

Nice!

https://codereview.chromium.org/2875143003/diff/1/third_party/googletest/cust...
File third_party/googletest/custom/gtest/internal/custom/gtest-port.h (right):

https://codereview.chromium.org/2875143003/diff/1/third_party/googletest/cust...
third_party/googletest/custom/gtest/internal/custom/gtest-port.h:9: #define
GTEST_API_
Can't we just add this as a -D flag
(https://cs.chromium.org/search/?q=defines+file:%5C.gn+package:%5Echromium$&ty...
Creating a whole file for this seems like a bit of overkill

[commit-bot: I haz the power, 2017-05-12 03:55:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 03:55:21]

Dry run: This issue passed the CQ dry run.

[pwnall, 2017-05-12 06:34:03]

The CQ bit was checked by pwnall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 06:34:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwnall, 2017-05-12 06:40:28]

Thank you very much for the quick response!

PTAL? Sorry for the rebase that snuck in.

https://codereview.chromium.org/2875143003/diff/1/third_party/googletest/cust...
File third_party/googletest/custom/gtest/internal/custom/gtest-port.h (right):

https://codereview.chromium.org/2875143003/diff/1/third_party/googletest/cust...
third_party/googletest/custom/gtest/internal/custom/gtest-port.h:9: #define
GTEST_API_
On 2017/05/12 01:21:12, Nico wrote:
> Can't we just add this as a -D flag
>
(https://cs.chromium.org/search/?q=defines+file:%5C.gn+package:%5Echromium$&ty...
> Creating a whole file for this seems like a bit of overkill

Done.
TBH, I liked the fact that this implicitly set up gtest for any future expansion
we might want to do (custom printers perhaps?).

I added a flag, and moved the include path back to gmock, but I left the
directory name as "custom" instead of "gmock_custom", to make it easier to see
that gtest custom includes should be added there too (accompanied by an include
path change).

[commit-bot: I haz the power, 2017-05-12 08:05:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 08:05:38]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Nico, 2017-05-12 10:16:12]

lgtm

[agl, 2017-05-12 14:56:13]

lgtm

[Nico, 2017-05-12 14:56:41]

The CQ bit was checked by thakis@chromium.org

[commit-bot: I haz the power, 2017-05-12 14:57:37]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 15:34:32]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494601001554280,
"parent_rev": "d99a64b9d3a8dc8417add42defbc1b7db421f9a7", "commit_rev":
"591b221c6a14bf529923e69df1ad93535ac5a626"}

[commit-bot: I haz the power, 2017-05-12 15:34:42]

Description was changed from

==========
Roll googletest to 1.8.0+.

BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init
==========

to

==========
Roll googletest to 1.8.0+.

BUG=630705
TESTED=out/Default/content_browsertests --gtest_filter=MojoTest.Init

Review-Url: https://codereview.chromium.org/2875143003
Cr-Commit-Position: refs/heads/master@{#471303}
Committed:
https://chromium.googlesource.com/chromium/src/+/591b221c6a14bf529923e69df1ad...
==========

[commit-bot: I haz the power, 2017-05-12 15:34:43]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/591b221c6a14bf529923e69df1ad...

[pwnall, 2017-05-12 16:35:01]

On 2017/05/12 15:34:43, commit-bot: I haz the power wrote:
> Committed patchset #2 (id:20001) as
>
https://chromium.googlesource.com/chromium/src/+/591b221c6a14bf529923e69df1ad...

thakis, agl: Thank you very much for your quick feedback!