third_party/googletest/README.chromium - Issue 2875143003: Roll googletest to 1.8.0+.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/googletest/README.chromium

Issue 2875143003: Roll googletest to 1.8.0+. (Closed)

Patch Set: Addressed feedback rebased. Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 Name: Google Test: Google's C++ Testing Framework	1 Name: Google Test: Google's C++ Testing Framework

2 Short Name: googletest	2 Short Name: googletest

3 URL: https://github.com/google/googletest.git	3 URL: https://github.com/google/googletest.git

4 Version: 1.7.0.git-43359642a1c16ad3f4fc575c7edd0cb935810815	4 Version: 1.8.0.git-8c7f93fedaca1b0158e67af0f5dd63a044066eab

5 License: BSD	5 License: BSD

6 Security critical: no	6 Security critical: no

7	7

8 Google Test is imported as-is, to facilitate version bumping. However, the	8 Google Test is imported as-is, to facilitate version bumping. However, the

9 file/directory layout of Google Test is not yet considered stable. Therefore,	9 file/directory layout of Google Test is not yet considered stable. Therefore,

10 until Google Test's layout stabilizes, Chromium code MUST NOT depend on it	10 until Google Test's layout stabilizes, Chromium code MUST NOT depend on it

11 directly. Instead, Chromium code MUST:	11 directly. Instead, Chromium code MUST:

12	12

13 * #include the headers in testing/gtest and testing/gmock	13 * #include the headers in testing/gtest and testing/gmock

14 * use //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main) in BUILD.gn	14 * use //testing/gtest(:gtest_main) and //testing/gmock(:gmock_main) in BUILD.gn

15 deps	15 deps

16	16

17 This will allow us to adapt to Google Test changes with minimal disruption.	17 This will allow us to adapt to Google Test changes with minimal disruption.

OLD	NEW