Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2875143002: Reduce boilerplate when creating simple mojom::URLLoaders. (Closed)

Created:
3 years, 7 months ago by jam
Modified:
3 years, 7 months ago
CC:
Aaron Boodman, abarth-chromium, alokp+watch_chromium.org, apacible+watch_chromium.org, asanka, chromium-reviews, darin (slow to review), darin-cc_chromium.org, erickung+watch_chromium.org, feature-media-reviews_chromium.org, jam, mfoltz+watch_chromium.org, miu+watch_chromium.org, mmenke, qsr+mojo_chromium.org, Randy Smith (Not in Mondays), viettrungluu+watch_chromium.org, xjz+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce boilerplate when creating simple mojom::URLLoaders. Add new constructors for mojo::DataPipe and content::ResourceRequestCompletionStatus to do this. BUG=717714 Review-Url: https://codereview.chromium.org/2875143002 Cr-Commit-Position: refs/heads/master@{#471129} Committed: https://chromium.googlesource.com/chromium/src/+/d3c312ef5df1fb4a6079c9df932adfcf295d880c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -101 lines) Patch
M content/browser/blob_storage/blob_internals_url_loader.cc View 2 chunks +2 lines, -18 lines 0 comments Download
M content/browser/histogram_internals_url_loader.cc View 1 chunk +2 lines, -19 lines 0 comments Download
M content/browser/webui/web_ui_url_loader_factory.cc View 2 chunks +2 lines, -17 lines 0 comments Download
M content/common/resource_request_completion_status.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/common/resource_request_completion_status.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M content/network/cache_url_loader.cc View 1 chunk +2 lines, -17 lines 0 comments Download
M content/network/url_loader_impl.cc View 1 chunk +1 line, -9 lines 0 comments Download
M media/mojo/common/mojo_decoder_buffer_converter.cc View 1 chunk +5 lines, -8 lines 0 comments Download
M media/mojo/common/mojo_decoder_buffer_converter_unittest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M media/remoting/demuxer_stream_adapter.cc View 1 chunk +1 line, -7 lines 0 comments Download
M mojo/public/cpp/system/data_pipe.h View 2 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
jam
3 years, 7 months ago (2017-05-11 20:17:44 UTC) #4
Ken Rockot(use gerrit already)
lgtm
3 years, 7 months ago (2017-05-11 20:56:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2875143002/1
3 years, 7 months ago (2017-05-11 23:05:13 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 23:58:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d3c312ef5df1fb4a6079c9df932a...

Powered by Google App Engine
This is Rietveld 408576698