Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: content/browser/blob_storage/blob_internals_url_loader.cc

Issue 2875143002: Reduce boilerplate when creating simple mojom::URLLoaders. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | content/browser/histogram_internals_url_loader.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/blob_storage/blob_internals_url_loader.h" 5 #include "content/browser/blob_storage/blob_internals_url_loader.h"
6 6
7 #include "content/browser/blob_storage/blob_internals_url_loader.h" 7 #include "content/browser/blob_storage/blob_internals_url_loader.h"
8 #include "content/browser/blob_storage/chrome_blob_storage_context.h" 8 #include "content/browser/blob_storage/chrome_blob_storage_context.h"
9 #include "storage/browser/blob/view_blob_internals_job.h" 9 #include "storage/browser/blob/view_blob_internals_job.h"
10 10
11 namespace content { 11 namespace content {
12 12
13 void StartBlobInternalsURLLoader( 13 void StartBlobInternalsURLLoader(
14 const ResourceRequest& request, 14 const ResourceRequest& request,
15 mojom::URLLoaderClientPtrInfo client_info, 15 mojom::URLLoaderClientPtrInfo client_info,
16 ChromeBlobStorageContext* blob_storage_context) { 16 ChromeBlobStorageContext* blob_storage_context) {
17 scoped_refptr<net::HttpResponseHeaders> headers( 17 scoped_refptr<net::HttpResponseHeaders> headers(
18 new net::HttpResponseHeaders("HTTP/1.1 200 OK")); 18 new net::HttpResponseHeaders("HTTP/1.1 200 OK"));
19 ResourceResponseHead resource_response; 19 ResourceResponseHead resource_response;
20 resource_response.headers = headers; 20 resource_response.headers = headers;
21 resource_response.mime_type = "text/html"; 21 resource_response.mime_type = "text/html";
22 22
23 mojom::URLLoaderClientPtr client; 23 mojom::URLLoaderClientPtr client;
24 client.Bind(std::move(client_info)); 24 client.Bind(std::move(client_info));
25 client->OnReceiveResponse(resource_response, base::nullopt, nullptr); 25 client->OnReceiveResponse(resource_response, base::nullopt, nullptr);
26 26
27 std::string output = storage::ViewBlobInternalsJob::GenerateHTML( 27 std::string output = storage::ViewBlobInternalsJob::GenerateHTML(
28 blob_storage_context->context()); 28 blob_storage_context->context());
29 29 mojo::DataPipe data_pipe(output.size());
30 MojoCreateDataPipeOptions options;
31 options.struct_size = sizeof(MojoCreateDataPipeOptions);
32 options.flags = MOJO_CREATE_DATA_PIPE_OPTIONS_FLAG_NONE;
33 options.element_num_bytes = 1;
34 options.capacity_num_bytes = output.size();
35 mojo::DataPipe data_pipe(options);
36
37 DCHECK(data_pipe.producer_handle.is_valid());
38 DCHECK(data_pipe.consumer_handle.is_valid());
39 30
40 void* buffer = nullptr; 31 void* buffer = nullptr;
41 uint32_t num_bytes = output.size(); 32 uint32_t num_bytes = output.size();
42 MojoResult result = 33 MojoResult result =
43 BeginWriteDataRaw(data_pipe.producer_handle.get(), &buffer, &num_bytes, 34 BeginWriteDataRaw(data_pipe.producer_handle.get(), &buffer, &num_bytes,
44 MOJO_WRITE_DATA_FLAG_NONE); 35 MOJO_WRITE_DATA_FLAG_NONE);
45 CHECK_EQ(result, MOJO_RESULT_OK); 36 CHECK_EQ(result, MOJO_RESULT_OK);
46 CHECK_EQ(num_bytes, output.size()); 37 CHECK_EQ(num_bytes, output.size());
47 38
48 memcpy(buffer, output.c_str(), output.size()); 39 memcpy(buffer, output.c_str(), output.size());
49 result = EndWriteDataRaw(data_pipe.producer_handle.get(), num_bytes); 40 result = EndWriteDataRaw(data_pipe.producer_handle.get(), num_bytes);
50 CHECK_EQ(result, MOJO_RESULT_OK); 41 CHECK_EQ(result, MOJO_RESULT_OK);
51 42
52 client->OnStartLoadingResponseBody(std::move(data_pipe.consumer_handle)); 43 client->OnStartLoadingResponseBody(std::move(data_pipe.consumer_handle));
53 44 client->OnComplete(ResourceRequestCompletionStatus(output.size()));
54 ResourceRequestCompletionStatus request_complete_data;
55 request_complete_data.error_code = net::OK;
56 request_complete_data.exists_in_cache = false;
57 request_complete_data.completion_time = base::TimeTicks::Now();
58 request_complete_data.encoded_data_length = output.size();
59 request_complete_data.encoded_body_length = output.size();
60 client->OnComplete(request_complete_data);
61 } 45 }
62 46
63 } // namespace content 47 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | content/browser/histogram_internals_url_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698