Move more variables to NQE params class

Move more variables to NQE params class

This CL completes moving of all param variables from estimator
class to the params class.

BUG=638308
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2875073004
Cr-Commit-Position: refs/heads/master@{#472345}
Committed: https://chromium.googlesource.com/chromium/src/+/b3285214d4c86c73b22af74b638266b202b9f894

[tbansal1, 2017-05-12 16:29:35]

Patchset #1 (id:1) has been deleted

[tbansal1, 2017-05-12 16:29:59]

Description was changed from

==========
Move more variables to NQE params class

This CL completes moving of all param variables from estimator
class to the params class.

BUG=638308
==========

to

==========
Move more variables to NQE params class

This CL completes moving of all param variables from estimator
class to the params class.

BUG=638308
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[tbansal1, 2017-05-12 16:31:22]

tbansal@chromium.org changed reviewers:
+ ryansturm@chromium.org

[tbansal1, 2017-05-12 16:31:23]

ryansturm: ptal. Thanks.

[tbansal1, 2017-05-12 16:31:28]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-12 16:32:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-12 17:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-12 17:54:23]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tbansal1, 2017-05-16 22:24:36]

ryansturm: ping!

[RyanSturm, 2017-05-16 22:36:55]

lgtm % nit

https://codereview.chromium.org/2875073004/diff/20001/net/nqe/network_quality...
File net/nqe/network_quality_estimator_params.h (right):

https://codereview.chromium.org/2875073004/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator_params.h:115: // observations are indexed by
ConnectionType.
If the second sentence is necessary, add something similar to the two things
below.

[tbansal1, 2017-05-16 23:06:57]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2017-05-16 23:07:37]

The CQ bit was checked by tbansal@chromium.org to run a CQ dry run

[tbansal1, 2017-05-16 23:07:41]

https://codereview.chromium.org/2875073004/diff/20001/net/nqe/network_quality...
File net/nqe/network_quality_estimator_params.h (right):

https://codereview.chromium.org/2875073004/diff/20001/net/nqe/network_quality...
net/nqe/network_quality_estimator_params.h:115: // observations are indexed by
ConnectionType.
On 2017/05/16 22:36:55, RyanSturm wrote:
> If the second sentence is necessary, add something similar to the two things
> below.

Done.

[commit-bot: I haz the power, 2017-05-16 23:08:40]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 03:10:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-17 03:10:51]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[tbansal1, 2017-05-17 05:57:53]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2017-05-17 05:57:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
ryansturm@chromium.org
Link to the patchset: https://codereview.chromium.org/2875073004/#ps60001
(title: "ryansturm comments")

[commit-bot: I haz the power, 2017-05-17 05:58:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-17 06:04:20]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1495000673772880,
"parent_rev": "5f5419e2fd0580d61810a824904fb1072c1fb541", "commit_rev":
"b3285214d4c86c73b22af74b638266b202b9f894"}

[commit-bot: I haz the power, 2017-05-17 06:04:32]

Description was changed from

==========
Move more variables to NQE params class

This CL completes moving of all param variables from estimator
class to the params class.

BUG=638308
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
Move more variables to NQE params class

This CL completes moving of all param variables from estimator
class to the params class.

BUG=638308
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2875073004
Cr-Commit-Position: refs/heads/master@{#472345}
Committed:
https://chromium.googlesource.com/chromium/src/+/b3285214d4c86c73b22af74b6382...
==========

[commit-bot: I haz the power, 2017-05-17 06:04:33]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/b3285214d4c86c73b22af74b6382...