Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: net/nqe/network_quality_estimator.h

Issue 2875073004: Move more variables to NQE params class (Closed)
Patch Set: ryansturm comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/nqe/network_quality_estimator.h
diff --git a/net/nqe/network_quality_estimator.h b/net/nqe/network_quality_estimator.h
index b68636a32525687261cc8d298c5a8beefbbf101f..bdf8488c6b1429d84bc039b824460390515952e2 100644
--- a/net/nqe/network_quality_estimator.h
+++ b/net/nqe/network_quality_estimator.h
@@ -537,12 +537,6 @@ class NET_EXPORT NetworkQualityEstimator
// throughput in kilobits per second.
void OnNewThroughputObservationAvailable(int32_t downstream_kbps);
- // Obtains the model parameters for different effective connection types from
- // the field trial parameters. For each effective connection type, a model
- // (currently composed of a RTT threshold and a downlink throughput threshold)
- // is provided by the field trial.
- void ObtainOperatingParams();
-
// Adds the default median RTT and downstream throughput estimate for the
// current connection type to the observation buffer.
void AddDefaultEstimates();
@@ -707,23 +701,6 @@ class NET_EXPORT NetworkQualityEstimator
// Buffer that holds RTT observations sorted by timestamp.
RttObservationBuffer rtt_observations_;
- // Default network quality observations obtained from the network quality
- // estimator field trial parameters. The observations are indexed by
- // ConnectionType.
- nqe::internal::NetworkQuality
- default_observations_[NetworkChangeNotifier::CONNECTION_LAST + 1];
-
- // Thresholds for different effective connection types obtained from field
- // trial variation params. These thresholds encode how different connection
- // types behave in general. In future, complex encodings (e.g., curve
- // fitting) may be used.
- nqe::internal::NetworkQuality connection_thresholds_
- [EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_LAST];
-
- // Typical network quality for different effective connection types.
- nqe::internal::NetworkQuality typical_network_quality_
- [EffectiveConnectionType::EFFECTIVE_CONNECTION_TYPE_LAST];
-
// Time when the transaction for the last main frame request was started.
base::TimeTicks last_main_frame_request_;
« no previous file with comments | « no previous file | net/nqe/network_quality_estimator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698