Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2874803003: Add support for built-in plugins (Closed)

Created:
3 years, 7 months ago by Brian Wilkerson
Modified:
3 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -83 lines) Patch
M pkg/analysis_server/lib/src/plugin/plugin_manager.dart View 10 chunks +91 lines, -15 lines 0 comments Download
M pkg/analysis_server/test/domain_completion_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/assists_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/edit/fixes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/src/domain_abstract_test.dart View 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/analysis_server/test/src/plugin/plugin_manager_test.dart View 7 chunks +87 lines, -12 lines 0 comments Download
M pkg/analyzer/lib/instrumentation/instrumentation.dart View 3 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer/test/instrumentation/instrumentation_test.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M pkg/analyzer_plugin/lib/plugin/plugin.dart View 2 chunks +3 lines, -1 line 0 comments Download
M pkg/analyzer_plugin/lib/src/channel/isolate_channel.dart View 6 chunks +105 lines, -28 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
A built-in plugin is one that is statically known to the server. I would like ...
3 years, 7 months ago (2017-05-10 19:58:57 UTC) #2
scheglov
LGTM
3 years, 7 months ago (2017-05-10 20:06:01 UTC) #3
Brian Wilkerson
3 years, 7 months ago (2017-05-10 20:31:25 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3b2c3ae5b285de71afa1bff59434bbe79895f4c7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698