Add support for built-in plugins

pkg/analyzer/lib/instrumentation/instrumentation.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.instrumentation.instrumentation;
 
 import 'dart:async';
 import 'dart:convert';
 
 import 'package:analyzer/task/model.dart';
@@ skipping 217 matching lines @@
       List<String> fields = <String>[
         TAG_PLUGIN_EXCEPTION,
         _toString(exception),
         _toString(stackTrace)
       ];
       plugin.addToFields(fields);
       _instrumentationServer.log(_join(fields));
     }
   }
 
-  void logPluginNotification(Uri pluginUri, String notification) {
+  void logPluginNotification(String pluginId, String notification) {
     if (_instrumentationServer != null) {
-      _instrumentationServer.log(
-          _join([TAG_PLUGIN_NOTIFICATION, _toString(pluginUri), notification]));
+      _instrumentationServer
+          .log(_join([TAG_PLUGIN_NOTIFICATION, pluginId, notification]));
     }
   }
 
-  void logPluginRequest(Uri pluginUri, String request) {
+  void logPluginRequest(String pluginId, String request) {
     if (_instrumentationServer != null) {
       _instrumentationServer
-          .log(_join([TAG_PLUGIN_REQUEST, _toString(pluginUri), request]));
+          .log(_join([TAG_PLUGIN_REQUEST, pluginId, request]));
     }
   }
 
-  void logPluginResponse(Uri pluginUri, String response) {
+  void logPluginResponse(String pluginId, String response) {
     if (_instrumentationServer != null) {
       _instrumentationServer
-          .log(_join([TAG_PLUGIN_RESPONSE, _toString(pluginUri), response]));
+          .log(_join([TAG_PLUGIN_RESPONSE, pluginId, response]));
     }
   }
 
   /**
    * Log that the given [plugin] took too long to execute the given [request].
    */
   void logPluginTimeout(PluginData plugin, String request) {
     if (_instrumentationServer != null) {
       List<String> fields = <String>[TAG_PLUGIN_TIMEOUT, request];
       plugin.addToFields(fields);
@@ skipping 203 matching lines @@
       await server.shutdown();
     }
   }
 }
 
 /**
  * Information about a plugin.
  */
 class PluginData {
   /**
-   * The path to the plugin.
+   * The id used to uniquely identify the plugin.
    */
-  final String path;
+  final String pluginId;
 
   /**
    * The name of the plugin.
    */
   final String name;
 
   /**
    * The version of the plugin.
    */
   final String version;
 
   /**
    * Initialize a newly created set of data about a plugin.
    */
-  PluginData(this.path, this.name, this.version);
+  PluginData(this.pluginId, this.name, this.version);
 
   /**
    * Add the information about the plugin to the list of [fields] to be sent to
    * the instrumentation server.
    */
   void addToFields(List<String> fields) {
-    fields.add(path);
+    fields.add(pluginId);
     if (name != null) {
       fields.add(name);
     }
     if (version != null) {
       fields.add(version);
     }
   }
 }