Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: pkg/analyzer/lib/instrumentation/instrumentation.dart

Issue 2874803003: Add support for built-in plugins (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/instrumentation/instrumentation.dart
diff --git a/pkg/analyzer/lib/instrumentation/instrumentation.dart b/pkg/analyzer/lib/instrumentation/instrumentation.dart
index 83d32a73b2640fb0b347b3ce4deec42a91b95a82..0deb0b6a876fee3a27109fc59b64bf1edda21d2c 100644
--- a/pkg/analyzer/lib/instrumentation/instrumentation.dart
+++ b/pkg/analyzer/lib/instrumentation/instrumentation.dart
@@ -235,24 +235,24 @@ class InstrumentationService {
}
}
- void logPluginNotification(Uri pluginUri, String notification) {
+ void logPluginNotification(String pluginId, String notification) {
if (_instrumentationServer != null) {
- _instrumentationServer.log(
- _join([TAG_PLUGIN_NOTIFICATION, _toString(pluginUri), notification]));
+ _instrumentationServer
+ .log(_join([TAG_PLUGIN_NOTIFICATION, pluginId, notification]));
}
}
- void logPluginRequest(Uri pluginUri, String request) {
+ void logPluginRequest(String pluginId, String request) {
if (_instrumentationServer != null) {
_instrumentationServer
- .log(_join([TAG_PLUGIN_REQUEST, _toString(pluginUri), request]));
+ .log(_join([TAG_PLUGIN_REQUEST, pluginId, request]));
}
}
- void logPluginResponse(Uri pluginUri, String response) {
+ void logPluginResponse(String pluginId, String response) {
if (_instrumentationServer != null) {
_instrumentationServer
- .log(_join([TAG_PLUGIN_RESPONSE, _toString(pluginUri), response]));
+ .log(_join([TAG_PLUGIN_RESPONSE, pluginId, response]));
}
}
@@ -476,9 +476,9 @@ class MulticastInstrumentationServer implements InstrumentationServer {
*/
class PluginData {
/**
- * The path to the plugin.
+ * The id used to uniquely identify the plugin.
*/
- final String path;
+ final String pluginId;
/**
* The name of the plugin.
@@ -493,14 +493,14 @@ class PluginData {
/**
* Initialize a newly created set of data about a plugin.
*/
- PluginData(this.path, this.name, this.version);
+ PluginData(this.pluginId, this.name, this.version);
/**
* Add the information about the plugin to the list of [fields] to be sent to
* the instrumentation server.
*/
void addToFields(List<String> fields) {
- fields.add(path);
+ fields.add(pluginId);
if (name != null) {
fields.add(name);
}

Powered by Google App Engine
This is Rietveld 408576698