Remove selected text when committing empty text

third_party/WebKit/Source/core/editing/Editor.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 1037 matching lines @@
 bool Editor::InsertText(const String& text, KeyboardEvent* triggering_event) {
   return GetFrame().GetEventHandler().HandleTextInputEvent(text,
                                                            triggering_event);
 }
 
 bool Editor::InsertTextWithoutSendingTextEvent(
     const String& text,
     bool select_inserted_text,
     TextEvent* triggering_event,
     InputEvent::InputType input_type) {
-  if (text.IsEmpty())
-    return false;
-
   const VisibleSelection& selection = SelectionForCommand(triggering_event);
   if (!selection.IsContentEditable())
     return false;
 
   GetSpellChecker().UpdateMarkersForWordsAffectedByEditing(
-      IsSpaceOrNewline(text[0]));
+      !text.IsEmpty() && IsSpaceOrNewline(text[0]));

[yosin_UTC9, 2017/05/12 05:06:14]

Good catch!

 
   // Insert the text
   TypingCommand::InsertText(
       *selection.Start().GetDocument(), text, selection.AsSelection(),
       select_inserted_text ? TypingCommand::kSelectInsertedText : 0,
       triggering_event && triggering_event->IsComposition()
           ? TypingCommand::kTextCompositionConfirm
           : TypingCommand::kTextCompositionNone,
       false, input_type);
 
@@ skipping 742 matching lines @@
 
 DEFINE_TRACE(Editor) {
   visitor->Trace(frame_);
   visitor->Trace(last_edit_command_);
   visitor->Trace(undo_stack_);
   visitor->Trace(mark_);
   visitor->Trace(typing_style_);
 }
 
 }  // namespace blink