Issue 2874763003: Add AddImmediate(reg, int) to ARM64 assembler

Issue 2874763003: Add AddImmediate(reg, int) to ARM64 assembler (Closed)

Created:
3 years, 7 months ago by erikcorry

Modified:
3 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Add AddImmediate(reg, int) to ARM64 assembler It's easier to port code between ARM and ARM64 if the assemblers support the same methods where possible. R=vegorov@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/efe0e76fedcdc79672e0f39cc8f981491e67b361

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+88 lines, -86 lines)			Patch
M	runtime/vm/assembler_arm.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	runtime/vm/assembler_arm.cc	View		3 chunks	+2 lines, -7 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm64.cc	View		8 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/assembler_arm64_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm64.cc	View		8 chunks	+8 lines, -9 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm.cc	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	runtime/vm/intrinsifier_arm64.cc	View		11 chunks	+23 lines, -23 lines	0 comments	Download
M	runtime/vm/stub_code_arm.cc	View		6 chunks	+6 lines, -6 lines	0 comments	Download
M	runtime/vm/stub_code_arm64.cc	View	1	18 chunks	+19 lines, -19 lines	0 comments	Download

Total messages: 4 (1 generated)

erikcorry

3 years, 7 months ago (2017-05-11 08:46:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
efe0e76fedcdc79672e0f39cc8f981491e67b361 (presubmit successful).