Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: runtime/vm/assembler_arm.cc

Issue 2874763003: Add AddImmediate(reg, int) to ARM64 assembler (Closed)
Patch Set: Fix bug Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_arm.cc
diff --git a/runtime/vm/assembler_arm.cc b/runtime/vm/assembler_arm.cc
index 11ed95d56e0dcbde4aaef754e4b6f432129d9759..85bf01a8f20fb56eab59135f7a057b407cfb41e9 100644
--- a/runtime/vm/assembler_arm.cc
+++ b/runtime/vm/assembler_arm.cc
@@ -1542,7 +1542,7 @@ void Assembler::MarkExceptionHandler(Label* label) {
void Assembler::Drop(intptr_t stack_elements) {
ASSERT(stack_elements >= 0);
if (stack_elements > 0) {
- AddImmediate(SP, SP, stack_elements * kWordSize);
+ AddImmediate(SP, stack_elements * kWordSize);
}
}
@@ -1594,7 +1594,7 @@ void Assembler::CheckCodePointer() {
const intptr_t offset = CodeSize() + Instr::kPCReadOffset +
Instructions::HeaderSize() - kHeapObjectTag;
mov(R0, Operand(PC));
- AddImmediate(R0, R0, -offset);
+ AddImmediate(R0, -offset);
ldr(IP, FieldAddress(CODE_REG, Code::saved_instructions_offset()));
cmp(R0, Operand(IP));
b(&instructions_ok, EQ);
@@ -3016,11 +3016,6 @@ void Assembler::CopyFloat64x2Field(Register dst,
}
-void Assembler::AddImmediate(Register rd, int32_t value, Condition cond) {
- AddImmediate(rd, rd, value, cond);
-}
-
-
void Assembler::AddImmediate(Register rd,
Register rn,
int32_t value,
« no previous file with comments | « runtime/vm/assembler_arm.h ('k') | runtime/vm/assembler_arm64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698