chrome/renderer/page_load_metrics/metrics_render_frame_observer.h - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Remove unnecessary variable Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

diff --git a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

index d0441b0a8aa5de061f538295f895a10f9cda28c9..12429692faa194a6ff1c690068c10601a097ae39 100644

--- a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

+++ b/chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

@@ -48,7 +48,7 @@ class MetricsRenderFrameObserver : public content::RenderFrameObserver {

void SendMetrics();

virtual bool ShouldSendMetrics() const;

- virtual PageLoadTiming GetTiming() const;

+ virtual mojom::PageLoadTimingPtr GetTiming() const;

virtual std::unique_ptr<base::Timer> CreateTimer() const;

virtual bool HasNoRenderFrame() const;