chrome/renderer/page_load_metrics/metrics_render_frame_observer.h - Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/page_load_metrics/metrics_render_frame_observer.h

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)

Patch Set: Remove unnecessary variable Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc ('k') | chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_	5 #ifndef CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_

6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_	6 #define CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_

7	7

8 #include <memory>	8 #include <memory>

9	9

10 #include "base/macros.h"	10 #include "base/macros.h"

(...skipping 30 matching lines...) Expand all Loading...
41 // Invoked when a frame is going away. This is our last chance to send IPCs	41 // Invoked when a frame is going away. This is our last chance to send IPCs

42 // before being destroyed.	42 // before being destroyed.

43 void FrameDetached() override;	43 void FrameDetached() override;

44	44

45 private:	45 private:

46 // Will be null when we're not actively sending metrics.	46 // Will be null when we're not actively sending metrics.

47 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;	47 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;

48	48

49 void SendMetrics();	49 void SendMetrics();

50 virtual bool ShouldSendMetrics() const;	50 virtual bool ShouldSendMetrics() const;

51 virtual PageLoadTiming GetTiming() const;	51 virtual mojom::PageLoadTimingPtr GetTiming() const;

52 virtual std::unique_ptr<base::Timer> CreateTimer() const;	52 virtual std::unique_ptr<base::Timer> CreateTimer() const;

53 virtual bool HasNoRenderFrame() const;	53 virtual bool HasNoRenderFrame() const;

54	54

55 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);	55 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);

56 };	56 };

57	57

58 } // namespace page_load_metrics	58 } // namespace page_load_metrics

59	59

60 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_	60 #endif // CHROME_RENDERER_PAGE_LOAD_METRICS_METRICS_RENDER_FRAME_OBSERVER_H_

OLD	NEW