Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6688)

Unified Diff: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc
diff --git a/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc b/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc
index 171a6701d60dbb2e67efb6e9a5265442737605b4..10e92f2c0be1cf9766b55803eb123fcdb9d2c3dc 100644
--- a/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc
+++ b/chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc
@@ -17,9 +17,9 @@ FakePageTimingMetricsIPCSender::~FakePageTimingMetricsIPCSender() {
}
void FakePageTimingMetricsIPCSender::ExpectPageLoadTiming(
- const PageLoadTiming& timing) {
+ const mojom::PageLoadTiming& timing) {
VerifyExpectedTimings();
- expected_timings_.push_back(timing);
+ expected_timings_.push_back(timing.Clone());
}
void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const {
@@ -28,7 +28,7 @@ void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const {
// the comments in the header file for additional details.
ASSERT_EQ(actual_timings_.size(), expected_timings_.size());
for (size_t i = 0; i < actual_timings_.size(); ++i) {
- if (actual_timings_.at(i) == expected_timings_.at(i))
+ if (actual_timings_.at(i)->Equals(*expected_timings_.at(i)))
continue;
ADD_FAILURE() << "Actual timing != expected timing at index " << i;
}
@@ -45,9 +45,9 @@ bool FakePageTimingMetricsIPCSender::Send(IPC::Message* message) {
}
void FakePageTimingMetricsIPCSender::OnTimingUpdated(
- const PageLoadTiming& timing,
- PageLoadMetadata metadata) {
- actual_timings_.push_back(timing);
+ const mojom::PageLoadTiming& timing,
+ mojom::PageLoadMetadata metadata) {
+ actual_timings_.push_back(timing.Clone());
VerifyExpectedTimings();
}

Powered by Google App Engine
This is Rietveld 408576698