Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender.cc

Issue 2874663005: [Page Load Metrics] Add mojom file to page load metrics. (Closed)
Patch Set: Remove unnecessary variable Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h" 5 #include "chrome/common/page_load_metrics/page_load_metrics_messages.h"
6 #include "chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender. h" 6 #include "chrome/renderer/page_load_metrics/fake_page_timing_metrics_ipc_sender. h"
7 #include "ipc/ipc_message.h" 7 #include "ipc/ipc_message.h"
8 #include "ipc/ipc_message_macros.h" 8 #include "ipc/ipc_message_macros.h"
9 #include "testing/gtest/include/gtest/gtest.h" 9 #include "testing/gtest/include/gtest/gtest.h"
10 10
11 namespace page_load_metrics { 11 namespace page_load_metrics {
12 12
13 FakePageTimingMetricsIPCSender::FakePageTimingMetricsIPCSender() {} 13 FakePageTimingMetricsIPCSender::FakePageTimingMetricsIPCSender() {}
14 14
15 FakePageTimingMetricsIPCSender::~FakePageTimingMetricsIPCSender() { 15 FakePageTimingMetricsIPCSender::~FakePageTimingMetricsIPCSender() {
16 VerifyExpectedTimings(); 16 VerifyExpectedTimings();
17 } 17 }
18 18
19 void FakePageTimingMetricsIPCSender::ExpectPageLoadTiming( 19 void FakePageTimingMetricsIPCSender::ExpectPageLoadTiming(
20 const PageLoadTiming& timing) { 20 const mojom::PageLoadTiming& timing) {
21 VerifyExpectedTimings(); 21 VerifyExpectedTimings();
22 expected_timings_.push_back(timing); 22 expected_timings_.push_back(timing.Clone());
23 } 23 }
24 24
25 void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const { 25 void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const {
26 // Ideally we'd just call ASSERT_EQ(actual_timings_, expected_timings_) here, 26 // Ideally we'd just call ASSERT_EQ(actual_timings_, expected_timings_) here,
27 // but this causes the generated gtest code to fail to build on Windows. See 27 // but this causes the generated gtest code to fail to build on Windows. See
28 // the comments in the header file for additional details. 28 // the comments in the header file for additional details.
29 ASSERT_EQ(actual_timings_.size(), expected_timings_.size()); 29 ASSERT_EQ(actual_timings_.size(), expected_timings_.size());
30 for (size_t i = 0; i < actual_timings_.size(); ++i) { 30 for (size_t i = 0; i < actual_timings_.size(); ++i) {
31 if (actual_timings_.at(i) == expected_timings_.at(i)) 31 if (actual_timings_.at(i)->Equals(*expected_timings_.at(i)))
32 continue; 32 continue;
33 ADD_FAILURE() << "Actual timing != expected timing at index " << i; 33 ADD_FAILURE() << "Actual timing != expected timing at index " << i;
34 } 34 }
35 } 35 }
36 36
37 bool FakePageTimingMetricsIPCSender::Send(IPC::Message* message) { 37 bool FakePageTimingMetricsIPCSender::Send(IPC::Message* message) {
38 IPC_BEGIN_MESSAGE_MAP(FakePageTimingMetricsIPCSender, *message) 38 IPC_BEGIN_MESSAGE_MAP(FakePageTimingMetricsIPCSender, *message)
39 IPC_MESSAGE_HANDLER(PageLoadMetricsMsg_TimingUpdated, OnTimingUpdated) 39 IPC_MESSAGE_HANDLER(PageLoadMetricsMsg_TimingUpdated, OnTimingUpdated)
40 IPC_MESSAGE_UNHANDLED(ADD_FAILURE()) 40 IPC_MESSAGE_UNHANDLED(ADD_FAILURE())
41 IPC_END_MESSAGE_MAP() 41 IPC_END_MESSAGE_MAP()
42 42
43 delete message; 43 delete message;
44 return true; 44 return true;
45 } 45 }
46 46
47 void FakePageTimingMetricsIPCSender::OnTimingUpdated( 47 void FakePageTimingMetricsIPCSender::OnTimingUpdated(
48 const PageLoadTiming& timing, 48 const mojom::PageLoadTiming& timing,
49 PageLoadMetadata metadata) { 49 mojom::PageLoadMetadata metadata) {
50 actual_timings_.push_back(timing); 50 actual_timings_.push_back(timing.Clone());
51 VerifyExpectedTimings(); 51 VerifyExpectedTimings();
52 } 52 }
53 53
54 } // namespace page_load_metrics 54 } // namespace page_load_metrics
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698