Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2874653002:
Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest (Closed)
DescriptionAdd the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest
This tries to mimic the current commandline opion of
./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run
test case in WebKit/PerformanceTests/.. directory using the command:
./tools/perf/run_benchmark blink_perf --test-path=<path to test cases>
For examples, after this CL, users can invoke:
* './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html'
command to run only color-changes-measure-frame-time.html test.
* './tools/perf/run_benchmark blink_perf --test-path=TestData/'
command to run all the tests in WebKit/PerformanceTests/TestData/ directory.
This is a lot more convenient for users who are wanting to add new test cases in
directories that aren't already covered by existing blink_perf.* benchmarks.
This benchmark is added to tools/perf/contrib/ directory because it isn't meant
to be scheduled on the perf waterfall.
BUG=720772
Review-Url: https://codereview.chromium.org/2874653002
Cr-Commit-Position: refs/heads/master@{#471028}
Committed: https://chromium.googlesource.com/chromium/src/+/3d449e8c4d349c0e4540a1d804920190ca76377c
Patch Set 1 #
Total comments: 10
Patch Set 2 : Address some review comments #Patch Set 3 : Use option instead of positional args #
Total comments: 3
Patch Set 4 : Address Charlie's comments #
Messages
Total messages: 27 (16 generated)
Description was changed from ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples: './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command will run only color-changes-measure-frame-time.html test. './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command will run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that arent' already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. ========== to ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command will run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that arent' already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ==========
nednguyen@google.com changed reviewers: + charliea@chromium.org, wangxianzhu@chromium.org
Description was changed from ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command will run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that arent' already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ========== to ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that arent' already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ==========
Description was changed from ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that arent' already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ========== to ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ==========
Description was changed from ========== Add a local run only blink_perf benchmark that supports running any subdir of WebKit/PerformanceTests This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ========== to ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ==========
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... File tools/perf/contrib/blink_perf_cmdline/OWNERS (right): https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/OWNERS:3: wangxianzhu@chromium.org https://cs.chromium.org/chromium/src/tools/perf/contrib/README.md says that the OWNERS file needs to be reviewed separately. https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... File tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py (right): https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:18: parser.error('Too many arguments.') 1. Does it still support options like --browser, --show-stdout? 2. Can the user get instructions with --help? https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:22: path = options.positional_args[1] I think it would be more convenient if the path is relative to BLINK_PERF_BASE_DIR.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... File tools/perf/contrib/blink_perf_cmdline/OWNERS (right): https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/OWNERS:3: wangxianzhu@chromium.org On 2017/05/10 02:55:37, Xianzhu wrote: > https://cs.chromium.org/chromium/src/tools/perf/contrib/README.md says that the > OWNERS file needs to be reviewed separately. Right. Once you approve this CL, I will send the OWNERS file to a separate file. https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... File tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py (right): https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:18: parser.error('Too many arguments.') On 2017/05/10 02:55:37, Xianzhu wrote: > 1. Does it still support options like --browser, --show-stdout? > 2. Can the user get instructions with --help? 1. Yes. 2. Good question. It could be hard to augment this benchmark's own help related to positional args to the overall help, but lemme see what I can do here. https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:22: path = options.positional_args[1] On 2017/05/10 02:55:37, Xianzhu wrote: > I think it would be more convenient if the path is relative to > BLINK_PERF_BASE_DIR. whynotboth.gif? since the other way is good for commandline auto-complete.
https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... File tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py (right): https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:18: parser.error('Too many arguments.') On 2017/05/10 17:23:42, nednguyen wrote: > On 2017/05/10 02:55:37, Xianzhu wrote: > > 1. Does it still support options like --browser, --show-stdout? > > 2. Can the user get instructions with --help? > > 1. Yes. > 2. Good question. It could be hard to augment this benchmark's own help related > to positional args to the overall help, but lemme see what I can do here. Like charliea asked in https://codereview.chromium.org/2873183002/, I also prefer options to positional args. Options requires more typing, but provides better way for users to discover features. https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:22: path = options.positional_args[1] On 2017/05/10 17:23:42, nednguyen wrote: > On 2017/05/10 02:55:37, Xianzhu wrote: > > I think it would be more convenient if the path is relative to > > BLINK_PERF_BASE_DIR. > > whynotboth.gif? since the other way is good for commandline auto-complete. Supporting both will be great :), just like run-webkit-tests and 'content_shell --run-layout-test' supporting both real paths and paths relative to LayoutTests directory. Can you add it in this CL?
https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... File tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py (right): https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:18: parser.error('Too many arguments.') On 2017/05/10 18:01:28, Xianzhu wrote: > On 2017/05/10 17:23:42, nednguyen wrote: > > On 2017/05/10 02:55:37, Xianzhu wrote: > > > 1. Does it still support options like --browser, --show-stdout? > > > 2. Can the user get instructions with --help? > > > > 1. Yes. > > 2. Good question. It could be hard to augment this benchmark's own help > related > > to positional args to the overall help, but lemme see what I can do here. > > Like charliea asked in https://codereview.chromium.org/2873183002/, I also > prefer options to positional args. Options requires more typing, but provides > better way for users to discover features. Done. There is no need for the other CL then. https://codereview.chromium.org/2874653002/diff/1/tools/perf/contrib/blink_pe... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:22: path = options.positional_args[1] On 2017/05/10 18:01:28, Xianzhu wrote: > On 2017/05/10 17:23:42, nednguyen wrote: > > On 2017/05/10 02:55:37, Xianzhu wrote: > > > I think it would be more convenient if the path is relative to > > > BLINK_PERF_BASE_DIR. > > > > whynotboth.gif? since the other way is good for commandline auto-complete. > > Supporting both will be great :), just like run-webkit-tests and 'content_shell > --run-layout-test' supporting both real paths and paths relative to LayoutTests > directory. Can you add it in this CL? Done.
Description was changed from ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf <path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf third_party/WebKit/PerformanceTests/TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ========== to ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ==========
lgtm
Description was changed from ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. This CL depends on https://codereview.chromium.org/2873183002/ ========== to ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. ==========
https://codereview.chromium.org/2874653002/diff/40001/tools/perf/contrib/blin... File tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py (right): https://codereview.chromium.org/2874653002/diff/40001/tools/perf/contrib/blin... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:20: help=('path to blink perf tests. Could be absolute path, ' Maybe: "Path to blink perf tests. Could be an absolute path, a relative path with respect to your current directory, a relative path with respect to third_party/WebKit/PerformanceTest" https://codereview.chromium.org/2874653002/diff/40001/tools/perf/contrib/blin... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:20: help=('path to blink perf tests. Could be absolute path, ' This doesn't make it quite clear whether you're allowed to pass a single test or multiple tests? Or a directory?
https://codereview.chromium.org/2874653002/diff/40001/tools/perf/contrib/blin... File tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py (right): https://codereview.chromium.org/2874653002/diff/40001/tools/perf/contrib/blin... tools/perf/contrib/blink_perf_cmdline/blink_perf_cmdline.py:20: help=('path to blink perf tests. Could be absolute path, ' On 2017/05/10 20:59:16, charliea wrote: > Maybe: > > "Path to blink perf tests. Could be an absolute path, a relative path with > respect to your current directory, a relative path with respect to > third_party/WebKit/PerformanceTest" Done.
lgtm thanks!
The CQ bit was checked by nednguyen@google.com
The patchset sent to the CQ was uploaded after l-g-t-m from wangxianzhu@chromium.org Link to the patchset: https://codereview.chromium.org/2874653002/#ps60001 (title: "Address Charlie's comments")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. ========== to ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. BUG=720772 ==========
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494524240861760,
"parent_rev": "4d1357d65728d99aef9de10f4ab8a914cb09b96d", "commit_rev":
"3d449e8c4d349c0e4540a1d804920190ca76377c"}
Message was sent while issue was closed.
Description was changed from ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. BUG=720772 ========== to ========== Add the local blink_perf benchmark that supports running any subdir of WebKit/PerformanceTest This tries to mimic the current commandline opion of ./third_party/WebKit/Tools/Scripts/run-perf-tests. i.e: user now can run test case in WebKit/PerformanceTests/.. directory using the command: ./tools/perf/run_benchmark blink_perf --test-path=<path to test cases> For examples, after this CL, users can invoke: * './tools/perf/run_benchmark blink_perf --test-path=third_party/WebKit/PerformanceTests/TestData/color-changes-measure-frame-time.html' command to run only color-changes-measure-frame-time.html test. * './tools/perf/run_benchmark blink_perf --test-path=TestData/' command to run all the tests in WebKit/PerformanceTests/TestData/ directory. This is a lot more convenient for users who are wanting to add new test cases in directories that aren't already covered by existing blink_perf.* benchmarks. This benchmark is added to tools/perf/contrib/ directory because it isn't meant to be scheduled on the perf waterfall. BUG=720772 Review-Url: https://codereview.chromium.org/2874653002 Cr-Commit-Position: refs/heads/master@{#471028} Committed: https://chromium.googlesource.com/chromium/src/+/3d449e8c4d349c0e4540a1d80492... ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as https://chromium.googlesource.com/chromium/src/+/3d449e8c4d349c0e4540a1d80492... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
