Chromium Code Reviews| OLD | NEW |
|---|---|
| (Empty) | |
| 1 # Copyright 2017 The Chromium Authors. All rights reserved. | |
| 2 # Use of this source code is governed by a BSD-style license that can be | |
| 3 # found in the LICENSE file. | |
| 4 | |
| 5 from benchmarks import blink_perf | |
| 6 | |
| 7 | |
| 8 # pylint: disable=protected-access | |
| 9 class BlinkPerfAll(blink_perf._BlinkPerfBenchmark): | |
| 10 | |
| 11 @classmethod | |
| 12 def Name(cls): | |
| 13 return 'blink_perf' | |
| 14 | |
| 15 @classmethod | |
| 16 def ProcessCommandLineArgs(cls, parser, args): | |
| 17 if len(args.positional_args) > 2: | |
| 18 parser.error('Too many arguments.') | |
|
Xianzhu
2017/05/10 02:55:37
1. Does it still support options like --browser, -
nednguyen
2017/05/10 17:23:42
1. Yes.
2. Good question. It could be hard to augm
Xianzhu
2017/05/10 18:01:28
Like charliea asked in https://codereview.chromium
nednguyen
2017/05/10 20:30:44
Done. There is no need for the other CL then.
| |
| 19 | |
| 20 def CreateStorySet(self, options): | |
| 21 if len(options.positional_args) > 1: | |
| 22 path = options.positional_args[1] | |
|
Xianzhu
2017/05/10 02:55:37
I think it would be more convenient if the path is
nednguyen
2017/05/10 17:23:42
whynotboth.gif? since the other way is good for co
Xianzhu
2017/05/10 18:01:28
Supporting both will be great :), just like run-we
nednguyen
2017/05/10 20:30:44
Done.
| |
| 23 else: | |
| 24 path = blink_perf.BLINK_PERF_BASE_DIR | |
| 25 print 'Running all blink_perf tests. This will take a long time...' | |
| 26 return blink_perf.CreateStorySetFromPath(path, blink_perf.SKIPPED_FILE) | |
| OLD | NEW |