Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2874363002: [DevTools] Make async step in marker contiguous (Closed)

Created:
3 years, 7 months ago by dgozman
Modified:
3 years, 7 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Make async step in marker contiguous When there are multiple tokens in async step in marker, they should still be hovered all together. BUG=none Review-Url: https://codereview.chromium.org/2874363002 Cr-Commit-Position: refs/heads/master@{#471447} Committed: https://chromium.googlesource.com/chromium/src/+/08aa82af5442daf861618f9f3511a0c6e20ae76a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptSourceFrame.js View 2 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/cmdevtools.css View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
dgozman
Take a look please.
3 years, 7 months ago (2017-05-12 00:53:25 UTC) #2
kozy
lgtm
3 years, 7 months ago (2017-05-12 06:57:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874363002/1
3 years, 7 months ago (2017-05-12 14:59:37 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/443057)
3 years, 7 months ago (2017-05-12 19:05:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874363002/1
3 years, 7 months ago (2017-05-12 19:14:50 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 21:30:57 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/08aa82af5442daf861618f9f3511...

Powered by Google App Engine
This is Rietveld 408576698