Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 2874333002: Construct QuicSocketAddressImpl in QuicChromiumPacketReadder and pass it by const&. (Closed)

Created:
3 years, 7 months ago by ianswett
Modified:
3 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Construct QuicSocketAddressImpl in QuicChromiumPacketReadder and pass it by const&. R=rch@chromium.org BUG= Review-Url: https://codereview.chromium.org/2874333002 Cr-Commit-Position: refs/heads/master@{#471175} Committed: https://chromium.googlesource.com/chromium/src/+/7d9211c6e72836d27193befaf71629a6e47ddb8b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -24 lines) Patch
M net/quic/chromium/quic_chromium_client_session.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_client_session.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M net/quic/chromium/quic_chromium_packet_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/quic/chromium/quic_chromium_packet_reader.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/platform/api/quic_socket_address.h View 1 chunk +4 lines, -4 lines 0 comments Download
M net/quic/platform/api/quic_socket_address.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_simple_client.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
ianswett
3 years, 7 months ago (2017-05-11 21:56:24 UTC) #1
Ryan Hamilton
lgtm
3 years, 7 months ago (2017-05-11 21:57:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874333002/1
3 years, 7 months ago (2017-05-11 21:58:40 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/368771)
3 years, 7 months ago (2017-05-11 23:09:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874333002/1
3 years, 7 months ago (2017-05-12 00:30:54 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-12 01:53:37 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7d9211c6e72836d27193befaf716...

Powered by Google App Engine
This is Rietveld 408576698