net/quic/chromium/quic_chromium_packet_reader.h - Issue 2874333002: Construct QuicSocketAddressImpl in QuicChromiumPacketReadder and pass it by const&.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/quic/chromium/quic_chromium_packet_reader.h

Issue 2874333002: Construct QuicSocketAddressImpl in QuicChromiumPacketReadder and pass it by const&. (Closed)

Patch Set: Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/quic/chromium/quic_chromium_packet_reader.h

diff --git a/net/quic/chromium/quic_chromium_packet_reader.h b/net/quic/chromium/quic_chromium_packet_reader.h

index 8ab492a292019741bbbc297d4ea68e23441cca00..3918fc073d448c7fdafe0fcf31dcf39a87d28064 100644

--- a/net/quic/chromium/quic_chromium_packet_reader.h

+++ b/net/quic/chromium/quic_chromium_packet_reader.h

@@ -33,8 +33,8 @@ class NET_EXPORT_PRIVATE QuicChromiumPacketReader {

virtual void OnReadError(int result,

const DatagramClientSocket* socket) = 0;

virtual bool OnPacket(const QuicReceivedPacket& packet,

- const IPEndPoint& local_address,

- const IPEndPoint& peer_address) = 0;

+ const QuicSocketAddress& local_address,

+ const QuicSocketAddress& peer_address) = 0;

};

QuicChromiumPacketReader(DatagramClientSocket* socket,