Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issue 2874143002: [CRD iOS] Some fixes for rendering (Closed)

Created:
3 years, 7 months ago by Yuwei
Modified:
3 years, 7 months ago
Reviewers:
nicholss
CC:
chromium-reviews, ios-reviews_chromium.org, chromoting-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[CRD iOS] Some fixes for rendering This CL has these fixes: 1. Removed the glViewport call since it doesn't account for the screen DPI in iOS client and it isn't required by either the Android or the iOS client. See explanation in comments. 2. Do not reset the viewport if the new screen/desktop size have not changed, since viewDidLayoutSubviews: may be called while the frame size is not changed. 3. Fix the issue that the first rendered frame may not be shown on the screen and explain with comments. 4. Releases the GlDisplayHandlerCore when disconnected. Review-Url: https://codereview.chromium.org/2874143002 Cr-Commit-Position: refs/heads/master@{#471036} Committed: https://chromium.googlesource.com/chromium/src/+/8e887d183b8176e14c6800b47fc97ab67fc1957a

Patch Set 1 #

Patch Set 2 : Just use presentRenderbuffer to swap buffers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -10 lines) Patch
M remoting/client/desktop_viewport.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M remoting/client/display/canvas.h View 1 chunk +4 lines, -1 line 0 comments Download
M remoting/client/display/gl_canvas.cc View 1 chunk +0 lines, -1 line 0 comments Download
M remoting/client/jni/jni_gl_display_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M remoting/ios/app/host_view_controller.mm View 2 chunks +11 lines, -2 lines 0 comments Download
M remoting/ios/display/gl_display_handler.mm View 1 6 chunks +12 lines, -6 lines 0 comments Download
M remoting/ios/session/remoting_client.mm View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Yuwei
PTAL thanks!
3 years, 7 months ago (2017-05-11 06:11:59 UTC) #3
nicholss
LGTM I am not quite ready to send out my CL yet: https://codereview.chromium.org/2869303003/ But in ...
3 years, 7 months ago (2017-05-11 15:19:50 UTC) #4
Yuwei
On 2017/05/11 15:19:50, nicholss wrote: > LGTM > > I am not quite ready to ...
3 years, 7 months ago (2017-05-11 18:51:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2874143002/20001
3 years, 7 months ago (2017-05-11 18:52:27 UTC) #7
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 19:16:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/8e887d183b8176e14c6800b47fc9...

Powered by Google App Engine
This is Rietveld 408576698