Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Issue 2874023003: Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority (Closed)

Created:
3 years, 7 months ago by Yusuke Sato
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make much sense because the processes are user-visible to some extent and because of that, they will likely respawn immediately after being killed. BUG=706048 TEST=try TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite the kill-respawn loop. Review-Url: https://codereview.chromium.org/2852093003 Cr-Commit-Position: refs/heads/master@{#468788} (cherry picked from commit b9b315ec73b88bebaaa1b45dd85b338392eb8fef) Review-Url: https://codereview.chromium.org/2874023003 . Cr-Commit-Position: refs/branch-heads/3071@{#509} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/22a4c0ee2fa868cb6560730ab8e579ddccb8c09c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -4 lines) Patch
M chrome/browser/memory/tab_manager_delegate_chromeos.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/memory/tab_manager_delegate_chromeos_unittest.cc View 3 chunks +10 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Yusuke Sato
3 years, 7 months ago (2017-05-11 04:14:23 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
22a4c0ee2fa868cb6560730ab8e579ddccb8c09c.

Powered by Google App Engine
This is Rietveld 408576698