Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.

Review-Url: https://codereview.chromium.org/2852093003
Cr-Commit-Position: refs/heads/master@{#468788}
Committed: https://chromium.googlesource.com/chromium/src/+/b9b315ec73b88bebaaa1b45dd85b338392eb8fef

[Yusuke Sato, 2017-05-01 20:23:20]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 20:24:01]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-05-01 21:29:45]

The CQ bit was checked by yusukes@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-01 21:30:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yusuke Sato, 2017-05-01 21:32:27]

yusukes@chromium.org changed reviewers:
+ cylee@chromium.org, lhchavez@chromium.org

[Yusuke Sato, 2017-05-01 21:32:28]

Luis, Cheng-Yu, PTAL.

[Luis Héctor Chávez, 2017-05-01 21:39:18]

lgtm

[Luis Héctor Chávez, 2017-05-01 21:39:44]

ah just one nit: s/Activly/Actively/ in the commit message.

[commit-bot: I haz the power, 2017-05-01 21:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-01 21:59:52]

Dry run: This issue passed the CQ dry run.

[Yusuke Sato, 2017-05-01 22:56:01]

Description was changed from

==========
Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Activly killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.
==========

to

==========
Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.
==========

[Yusuke Sato, 2017-05-01 22:56:14]

Description was changed from

==========
Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.
==========

to

==========
Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.
==========

[Yusuke Sato, 2017-05-01 22:56:23]

oops, done.

[Yusuke Sato, 2017-05-02 17:00:30]

cylee@ ping?

[cylee1, 2017-05-02 18:48:38]

lgtm

[cylee1, 2017-05-02 18:49:45]

cylee@chromium.org changed reviewers:
+ georgesak@chromium.org

[cylee1, 2017-05-02 18:49:46]

+George since I'm not in the OWNER list

[Yusuke Sato, 2017-05-02 19:49:20]

Thanks. Georges, please do an OWNER review.

[Georges Khalil, 2017-05-02 21:32:41]

lgtm

[Yusuke Sato, 2017-05-02 21:33:45]

The CQ bit was checked by yusukes@chromium.org

[commit-bot: I haz the power, 2017-05-02 21:34:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:05:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493760825271770,
"parent_rev": "5db093f59a68e29ed89a115da7e0c86b897a67b1", "commit_rev":
"b9b315ec73b88bebaaa1b45dd85b338392eb8fef"}

[commit-bot: I haz the power, 2017-05-02 22:05:28]

Description was changed from

==========
Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.
==========

to

==========
Don't kill a process if it has IMPORTANT_FOREGROUND or higher priority

Actively killing IMPORTANT_FOREGROUND processes in Chrome doesn't make
much sense because the processes are user-visible to some extent and
because of that, they will likely respawn immediately after being
killed.

BUG=706048
TEST=try
TEST=Follow crbug.com/706048#c76, confirm we no longer see infinite
 the kill-respawn loop.

Review-Url: https://codereview.chromium.org/2852093003
Cr-Commit-Position: refs/heads/master@{#468788}
Committed:
https://chromium.googlesource.com/chromium/src/+/b9b315ec73b88bebaaa1b45dd85b...
==========

[commit-bot: I haz the power, 2017-05-02 22:05:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b9b315ec73b88bebaaa1b45dd85b...