InfoBubble::ShowFocusless() added not to grab the focus when being shown....

InfoBubble::ShowFocusless() added not to grab the focus when being shown.
Interface taken from http://codereview.chromium.org/2682004.

BUG=http://crosbug.com/525
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50354

[glotov, 2010-06-21 10:13:48]

I mixed up the reviewer emails, sorry. Fixed now. Please have a look.

[Nikita (slow), 2010-06-21 11:53:06]

http://codereview.chromium.org/2874004/diff/7001/8003
File chrome/browser/views/info_bubble.h (right):

http://codereview.chromium.org/2874004/diff/7001/8003#newcode201
chrome/browser/views/info_bubble.h:201: static InfoBubble*
ShowNoGrab(views::Widget* parent,
Maybe it makes sense to rename this function?

There's a bit of confusion:
- MessageBubble has the same ShowNoGrab static function but it differs in params
(which are specific to MB initialization)
- ShowNoGrab is implemented differently for IB and MB (diff in types of
WidgetGtk created)
- IB is MB's base class.

http://codereview.chromium.org/2874004/diff/7001/8003#newcode201
chrome/browser/views/info_bubble.h:201: static InfoBubble*
ShowNoGrab(views::Widget* parent,
Add comment about implementation details (that TYPE_POPUP WidgetGtk is created).

[glotov, 2010-06-21 12:21:58]

http://codereview.chromium.org/2874004/diff/7001/8003
File chrome/browser/views/info_bubble.h (right):

http://codereview.chromium.org/2874004/diff/7001/8003#newcode201
chrome/browser/views/info_bubble.h:201: static InfoBubble*
ShowNoGrab(views::Widget* parent,
On 2010/06/21 11:53:06, Nikita Kostylev wrote:
> Add comment about implementation details (that TYPE_POPUP WidgetGtk is
created).

Done.

http://codereview.chromium.org/2874004/diff/7001/8003#newcode201
chrome/browser/views/info_bubble.h:201: static InfoBubble*
ShowNoGrab(views::Widget* parent,
On 2010/06/21 11:53:06, Nikita Kostylev wrote:
> Maybe it makes sense to rename this function?
> 
> There's a bit of confusion:
> - MessageBubble has the same ShowNoGrab static function but it differs in
params
> (which are specific to MB initialization)
> - ShowNoGrab is implemented differently for IB and MB (diff in types of
> WidgetGtk created)
> - IB is MB's base class.

Done.

[Nikita (slow), 2010-06-21 12:37:28]

LGTM

http://codereview.chromium.org/2874004/diff/6002/12002
File chrome/browser/views/info_bubble.cc (right):

http://codereview.chromium.org/2874004/diff/6002/12002#newcode252
chrome/browser/views/info_bubble.cc:252: // TYPE_POPUP widget is used to archive
the focusless effect.
archive > achieve.
It better be moved to header?

[glotov, 2010-06-21 12:45:09]

http://codereview.chromium.org/2874004/diff/6002/12002
File chrome/browser/views/info_bubble.cc (right):

http://codereview.chromium.org/2874004/diff/6002/12002#newcode252
chrome/browser/views/info_bubble.cc:252: // TYPE_POPUP widget is used to archive
the focusless effect.
On 2010/06/21 12:37:29, Nikita Kostylev wrote:
> archive > achieve.
> It better be moved to header?

Done.