Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2682004: MessageBubble which does not require separate window and does not grab input on mouse press event. (Closed)

Created:
10 years, 6 months ago by oshima
Modified:
9 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

MessageBubble which does not require separate window and does not grab input on mouse press event. * Added new constructor to InfoBubble for chromeos which takes WidgetGtk::Type parameter * Made DoGrab/HandleGrabBroke so that subclass can customize its behavior. * Added MessageBubble::ShowNoGrab that shows a child MessageBubble which does not grab input on mouse press event. * Explicitly remove accelerator when closed. This is necessary for child, but doing for all case as it's harmless to do so. * Moved HandleGrabBroke to protected and made virtual so that sub class can trap the event. ScreenLocker will use this event to detect this. This will be used for screen locker. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49068

Patch Set 1 #

Patch Set 2 : " #

Total comments: 2

Patch Set 3 : moved HandleGrabBroke to protected section #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -19 lines) Patch
M chrome/browser/chromeos/login/message_bubble.h View 1 2 chunks +20 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/message_bubble.cc View 3 chunks +28 lines, -3 lines 0 comments Download
M chrome/browser/views/info_bubble.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/views/info_bubble.cc View 1 2 chunks +13 lines, -0 lines 0 comments Download
M views/widget/widget_gtk.h View 1 2 chunks +5 lines, -4 lines 0 comments Download
M views/widget/widget_gtk.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
oshima
10 years, 6 months ago (2010-06-05 03:45:12 UTC) #1
sky
http://codereview.chromium.org/2682004/diff/11001/12005 File views/widget/widget_gtk.h (right): http://codereview.chromium.org/2682004/diff/11001/12005#newcode280 views/widget/widget_gtk.h:280: virtual void HandleGrabBroke(); Move the implementation to match the ...
10 years, 6 months ago (2010-06-07 14:41:31 UTC) #2
oshima
http://codereview.chromium.org/2682004/diff/11001/12005 File views/widget/widget_gtk.h (right): http://codereview.chromium.org/2682004/diff/11001/12005#newcode280 views/widget/widget_gtk.h:280: virtual void HandleGrabBroke(); On 2010/06/07 14:41:31, sky wrote: > ...
10 years, 6 months ago (2010-06-07 16:05:54 UTC) #3
sky
10 years, 6 months ago (2010-06-07 16:11:43 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698