Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/views/info_bubble.cc

Issue 2874004: InfoBubble::ShowFocusless() added not to grab the focus when being shown.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/info_bubble.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/info_bubble.cc
===================================================================
--- chrome/browser/views/info_bubble.cc (revision 50336)
+++ chrome/browser/views/info_bubble.cc (working copy)
@@ -248,12 +248,27 @@
return window;
}
+#if defined(OS_CHROMEOS)
+// static
+InfoBubble* InfoBubble::ShowFocusless(
+ views::Widget* parent,
+ const gfx::Rect& position_relative_to,
+ BubbleBorder::ArrowLocation arrow_location,
+ views::View* contents,
+ InfoBubbleDelegate* delegate) {
+ InfoBubble* window = new InfoBubble(views::WidgetGtk::TYPE_POPUP);
+ window->Init(parent, position_relative_to, arrow_location,
+ contents, delegate);
+ return window;
+}
+#endif
+
void InfoBubble::Close() {
if (show_status_ != kOpen)
return;
show_status_ = kClosing;
-
+
if (fade_away_on_close_)
FadeOut();
else
@@ -460,7 +475,7 @@
if (action == WA_INACTIVE) {
Close();
} else if (action == WA_ACTIVE) {
- DCHECK(GetRootView()->GetChildViewCount() > 0);
+ DCHECK_GT(GetRootView()->GetChildViewCount(), 0);
GetRootView()->GetChildViewAt(0)->RequestFocus();
}
}
« no previous file with comments | « chrome/browser/views/info_bubble.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698