Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2873953002:
Introduce SelectedMap class to LayoutSelection::SetSelection() (Closed)
|
Created:
3 years, 7 months ago by yoichio Modified:
3 years, 7 months ago Reviewers:
yosin_UTC9 CC:
blink-reviews, chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionIntroduce SelectedMap class to LayoutSelection::SetSelection()
LayoutSelection::SetSelection defines 2 inner classes and 2 variables for that.
This CL defines the new class to combine them.
TEST=No change in behavior.
BUG=708453
Review-Url: https://codereview.chromium.org/2873953002
Cr-Commit-Position: refs/heads/master@{#470839}
Committed: https://chromium.googlesource.com/chromium/src/+/2a81fbab97384f01c8cb80d680d10e6bc6a95ebb
Patch Set 1 : update #
Total comments: 1
Messages
Total messages: 19 (12 generated)
Patchset #1 (id:1) has been deleted
The CQ bit was checked by yoichio@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yoichio@chromium.org changed reviewers: + yosin@chromium.org
Description was changed from ========== Introduce SelectedMap class to LayoutSelection::SetSelection() TEST=No change in behavior. BUG=708453 ========== to ========== Introduce SelectedMap class to LayoutSelection::SetSelection() LayoutSelection::SetSelection defines 2 inner classes and 2 variables for that. This CL defines the new class to combine them. TEST=No change in behavior. BUG=708453 ==========
lgtm w/ small nit https://codereview.chromium.org/2873953002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/editing/LayoutSelection.cpp (right): https://codereview.chromium.org/2873953002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/editing/LayoutSelection.cpp:229: // FIXME: |new_selected_map| doesn't really need to store the nit: s/FIXME/TODO(editing-dev)/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by yoichio@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494478113609520,
"parent_rev": "68abbc297a0dfc01adcd944e92b6c13864750e84", "commit_rev":
"2a81fbab97384f01c8cb80d680d10e6bc6a95ebb"}
Message was sent while issue was closed.
Description was changed from ========== Introduce SelectedMap class to LayoutSelection::SetSelection() LayoutSelection::SetSelection defines 2 inner classes and 2 variables for that. This CL defines the new class to combine them. TEST=No change in behavior. BUG=708453 ========== to ========== Introduce SelectedMap class to LayoutSelection::SetSelection() LayoutSelection::SetSelection defines 2 inner classes and 2 variables for that. This CL defines the new class to combine them. TEST=No change in behavior. BUG=708453 Review-Url: https://codereview.chromium.org/2873953002 Cr-Commit-Position: refs/heads/master@{#470839} Committed: https://chromium.googlesource.com/chromium/src/+/2a81fbab97384f01c8cb80d680d1... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as https://chromium.googlesource.com/chromium/src/+/2a81fbab97384f01c8cb80d680d1... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
