Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 2873873004: Revert of Oilpan: Schedule an idle garbage collection after receiving (Closed)

Created:
3 years, 7 months ago by tzik
Modified:
3 years, 7 months ago
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Oilpan: Schedule an idle garbage collection after receiving the kGCCallbackScheduleIdleGarbageColle… (patchset #2 id:20001 of https://codereview.chromium.org/2871743002/ ) Reason for revert: This CL causes a compile error on the CI: https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/39399 The error log was: [46869/52874] CXX obj/third_party/WebKit/Source/core/core_generated/V8GCController.o FAILED: obj/third_party/WebKit/Source/core/core_generated/V8GCController.o (snip) ../../third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:446:21: error: no member named 'kGCCallbackScheduleIdleGarbageCollection' in namespace 'v8' if (flags & v8::kGCCallbackScheduleIdleGarbageCollection) { Original issue's description: > Oilpan: Schedule an idle garbage collection after receiving the kGCCallbackScheduleIdleGarbageCollection callback flag. > > BUG=chromium:718484 > NOTRY=true > > Review-Url: https://codereview.chromium.org/2871743002 > Cr-Commit-Position: refs/heads/master@{#470860} > Committed: https://chromium.googlesource.com/chromium/src/+/9b107d47bd61d2ed77c923ad22dca27b226c9236 TBR=haraken@chromium.org,hpayer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:718484 Review-Url: https://codereview.chromium.org/2873873004 Cr-Commit-Position: refs/heads/master@{#470865} Committed: https://chromium.googlesource.com/chromium/src/+/bcf974f311836b1b26cdc3969e6e9bf3211c0550

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tzik
Created Revert of Oilpan: Schedule an idle garbage collection after receiving the kGCCallbackScheduleIdleGarbageColle…
3 years, 7 months ago (2017-05-11 07:50:56 UTC) #2
haraken
LGTM to revert
3 years, 7 months ago (2017-05-11 07:52:11 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 07:52:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bcf974f311836b1b26cdc3969e6e...

Powered by Google App Engine
This is Rietveld 408576698