Oilpan: Schedule an idle garbage collection after receiving the kGCCallbackScheduleIdleGarbageColle…

Oilpan: Schedule an idle garbage collection after receiving the kGCCallbackScheduleIdleGarbageCollection callback flag.

BUG=chromium:718484
NOTRY=true

Review-Url: https://codereview.chromium.org/2871743002
Cr-Commit-Position: refs/heads/master@{#470860}
Committed: https://chromium.googlesource.com/chromium/src/+/9b107d47bd61d2ed77c923ad22dca27b226c9236

[Hannes Payer (out of office), 2017-05-08 20:08:27]

hpayer@chromium.org changed reviewers:
+ haraken@chromium.org

[haraken, 2017-05-08 23:56:23]

LGTM

https://codereview.chromium.org/2871743002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/2871743002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:445: if (flags &
v8::kGCCallbackScheduleIdleGarbageCollection) {

Add a comment about what this is doing.

[Hannes Payer (out of office), 2017-05-09 06:47:15]

https://codereview.chromium.org/2871743002/diff/1/third_party/WebKit/Source/b...
File third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp (right):

https://codereview.chromium.org/2871743002/diff/1/third_party/WebKit/Source/b...
third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:445: if (flags &
v8::kGCCallbackScheduleIdleGarbageCollection) {
On 2017/05/08 23:56:23, haraken wrote:
> 
> Add a comment about what this is doing.

Done.

[Hannes Payer (out of office), 2017-05-09 06:47:20]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-05-09 06:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2871743002/#ps20001
(title: "added comment")

[commit-bot: I haz the power, 2017-05-09 06:47:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 07:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-09 07:02:55]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Hannes Payer (out of office), 2017-05-09 09:40:09]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-05-09 09:40:12]

The CQ bit was unchecked by hpayer@chromium.org

[Hannes Payer (out of office), 2017-05-10 09:05:01]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2017-05-10 09:05:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 11:19:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 11:19:21]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hannes Payer (out of office), 2017-05-10 11:45:02]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2017-05-10 11:45:33]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 13:24:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 13:24:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hannes Payer (out of office), 2017-05-10 19:42:48]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2017-05-10 19:44:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 22:19:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 22:19:57]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Hannes Payer (out of office), 2017-05-11 07:21:21]

Description was changed from

==========
Oilpan: Schedule an idle garbage collection after receiving the
kGCCallbackScheduleIdleGarbageCollection callback flag.

BUG=
==========

to

==========
Oilpan: Schedule an idle garbage collection after receiving the
kGCCallbackScheduleIdleGarbageCollection callback flag.

BUG=chromium:718484
NOTRY=true
==========

[Hannes Payer (out of office), 2017-05-11 07:21:25]

The CQ bit was checked by hpayer@chromium.org

[commit-bot: I haz the power, 2017-05-11 07:22:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 07:27:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494487285067120,
"parent_rev": "a6e12ea8b088afa8c2135dcc3fa583bb4c5bc945", "commit_rev":
"9b107d47bd61d2ed77c923ad22dca27b226c9236"}

[commit-bot: I haz the power, 2017-05-11 07:27:31]

Description was changed from

==========
Oilpan: Schedule an idle garbage collection after receiving the
kGCCallbackScheduleIdleGarbageCollection callback flag.

BUG=chromium:718484
NOTRY=true
==========

to

==========
Oilpan: Schedule an idle garbage collection after receiving the
kGCCallbackScheduleIdleGarbageCollection callback flag.

BUG=chromium:718484
NOTRY=true

Review-Url: https://codereview.chromium.org/2871743002
Cr-Commit-Position: refs/heads/master@{#470860}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b107d47bd61d2ed77c923ad22dc...
==========

[commit-bot: I haz the power, 2017-05-11 07:27:33]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9b107d47bd61d2ed77c923ad22dc...

[tzik, 2017-05-11 07:50:55]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2873873004/ by tzik@chromium.org.

The reason for reverting is: This CL causes a compile error on the CI:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/39399

The error log was:
[46869/52874] CXX
obj/third_party/WebKit/Source/core/core_generated/V8GCController.o
FAILED: obj/third_party/WebKit/Source/core/core_generated/V8GCController.o 
(snip)
../../third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp:446:21:
error: no member named 'kGCCallbackScheduleIdleGarbageCollection' in namespace
'v8'
    if (flags & v8::kGCCallbackScheduleIdleGarbageCollection) {.

[findit-for-me, 2017-05-11 07:53:50]

Findit (https://goo.gl/kROfz5) confirmed this CL at revision 470860 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...