Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2873873002: Open the current URL if a WebAPK is opened from the context menu. (Closed)

Created:
3 years, 7 months ago by dominickn
Modified:
3 years, 7 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Open the current URL if a WebAPK is opened from the context menu. Currently, when a WebAPK is installed, Chrome displays "Open <appname>" in the context menu in place of "Add to home screen". When the user taps the link, the WebAPK is launched to its start_url. This may differ from the current URL that the user is on. This CL explicitly sets the URL to be opened to the current page URL. For example, if the user has installed mobile.twitter.com as a WebAPK, then navigates to mobile.twitter.com/username, tapping the menu item will open the Twitter WebAPK at the username's page rather than Twitter's start_url. BUG=699265 Review-Url: https://codereview.chromium.org/2864613002 Cr-Commit-Position: refs/heads/master@{#469908} (cherry picked from commit bb9cdc06b446bad7a85a602c26098a687bffd911) Review-Url: https://codereview.chromium.org/2873873002 . Cr-Commit-Position: refs/branch-heads/3071@{#495} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/1897fd7b954eabba92e440b6fe0d210089b23d14

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
dominickn
3 years, 7 months ago (2017-05-10 01:20:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1897fd7b954eabba92e440b6fe0d210089b23d14 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698