Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2864613002:
Open the current URL if a WebAPK is opened from the context menu. (Closed)
DescriptionOpen the current URL if a WebAPK is opened from the context menu.
Currently, when a WebAPK is installed, Chrome displays "Open <appname>"
in the context menu in place of "Add to home screen". When the user taps
the link, the WebAPK is launched to its start_url. This may differ from
the current URL that the user is on.
This CL explicitly sets the URL to be opened to the current page URL.
For example, if the user has installed mobile.twitter.com as a WebAPK,
then navigates to mobile.twitter.com/username, tapping the menu item
will open the Twitter WebAPK at the username's page rather than
Twitter's start_url.
BUG=699265
Review-Url: https://codereview.chromium.org/2864613002
Cr-Commit-Position: refs/heads/master@{#469908}
Committed: https://chromium.googlesource.com/chromium/src/+/bb9cdc06b446bad7a85a602c26098a687bffd911
Patch Set 1 #Patch Set 2 : Less redundant null checking #
Total comments: 2
Patch Set 3 : Use WebApkNavigationClient #Messages
Total messages: 23 (17 generated)
The CQ bit was checked by dominickn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
dominickn@chromium.org changed reviewers: + dfalcantara@chromium.org, pkotwicz@chromium.org
PTAL, thanks! Peter: sanity check for WebAPKs. Let's get this fix in now since it's easy, and we'll follow up on what we'll need to do with comment-signed WebAPKs. Dan: OWNERs
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
The CQ bit was checked by dominickn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
LGTM with nit https://codereview.chromium.org/2864613002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/2864613002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1911: launchIntent.setData(Uri.parse(currentTab.getUrl())); We might as well use WebApkNavigationClient#createLaunchWebApkIntent()
The CQ bit was checked by dominickn@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks! https://codereview.chromium.org/2864613002/diff/20001/chrome/android/java/src... File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/2864613002/diff/20001/chrome/android/java/src... chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:1911: launchIntent.setData(Uri.parse(currentTab.getUrl())); On 2017/05/05 22:02:17, pkotwicz wrote: > We might as well use WebApkNavigationClient#createLaunchWebApkIntent() Done.
The CQ bit was checked by dominickn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pkotwicz@chromium.org, dfalcantara@chromium.org Link to the patchset: https://codereview.chromium.org/2864613002/#ps40001 (title: "Use WebApkNavigationClient")
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494220226829490,
"parent_rev": "7f6264df1bd3a73c0f8af49adfc345126eebb1cd", "commit_rev":
"bb9cdc06b446bad7a85a602c26098a687bffd911"}
Message was sent while issue was closed.
Description was changed from ========== Open the current URL if a WebAPK is opened from the context menu. Currently, when a WebAPK is installed, Chrome displays "Open <appname>" in the context menu in place of "Add to home screen". When the user taps the link, the WebAPK is launched to its start_url. This may differ from the current URL that the user is on. This CL explicitly sets the URL to be opened to the current page URL. For example, if the user has installed mobile.twitter.com as a WebAPK, then navigates to mobile.twitter.com/username, tapping the menu item will open the Twitter WebAPK at the username's page rather than Twitter's start_url. BUG=699265 ========== to ========== Open the current URL if a WebAPK is opened from the context menu. Currently, when a WebAPK is installed, Chrome displays "Open <appname>" in the context menu in place of "Add to home screen". When the user taps the link, the WebAPK is launched to its start_url. This may differ from the current URL that the user is on. This CL explicitly sets the URL to be opened to the current page URL. For example, if the user has installed mobile.twitter.com as a WebAPK, then navigates to mobile.twitter.com/username, tapping the menu item will open the Twitter WebAPK at the username's page rather than Twitter's start_url. BUG=699265 Review-Url: https://codereview.chromium.org/2864613002 Cr-Commit-Position: refs/heads/master@{#469908} Committed: https://chromium.googlesource.com/chromium/src/+/bb9cdc06b446bad7a85a602c2609... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/bb9cdc06b446bad7a85a602c2609... |
