Image Capture Android: make torch mode override other fill light mode(s)

Image Capture Android: make torch mode override other fill light mode(s)

Setting the torch (flash constantly on) should override other fill light
mode settings (i.e. off/auto/always).  This CL fixes that for both the
old and new API. Also, for the new API, torch needs the CONTROL_AE_MODE 
specified.

(This CL does not fix the auto/always flash not working properly in 
the new API because this needs a dance of CONTROL_AE_PRECAPTURE_TRIGGER 
manipulation worth a CL of its own).

BUG=720250
Review-Url: https://codereview.chromium.org/2873843004
Cr-Commit-Position: refs/heads/master@{#470774}
Committed: https://chromium.googlesource.com/chromium/src/+/b95ce72dc081549b258f2836aaf85c1c95b2356a

[mcasas, 2017-05-11 00:18:57]

Description was changed from

==========
Image Capture Android: make torch mode override other fill light mode(s)

Setting the torch (flash constantly on) should override other fill light
mode settings (i.e. off/auto/always).  This CL fixes that for both the
old and new API.

(This CL does not fix the auto/always flash being ignored bug because
this needs a dance some CONTROL_AE_PRECAPTURE_TRIGGER manipulation that
it's worth a CL on its own).

BUG=720250
==========

to

==========
Image Capture Android: make torch mode override other fill light mode(s)

Setting the torch (flash constantly on) should override other fill light
mode settings (i.e. off/auto/always).  This CL fixes that for both the
old and new API. Also, for the new API, torch needs the CONTROL_AE_MODE 
specified.

(This CL does not fix the auto/always flash not working properly in 
the new API because this needs a dance of CONTROL_AE_PRECAPTURE_TRIGGER 
manipulation worth a CL of its own).

BUG=720250
==========

[mcasas, 2017-05-11 00:19:19]

mcasas@chromium.org changed reviewers:
+ reillyg@chromium.org

[mcasas, 2017-05-11 00:19:20]

reillyg@ small CL, PTAL

[Reilly Grant (use Gerrit), 2017-05-11 01:32:42]

lgtm

[mcasas, 2017-05-11 01:34:40]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2017-05-11 01:35:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 02:11:36]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1494466480251060, "parent_rev":
"5b2fff30d156d502cde5f0e9ea52cdda9071375f", "commit_rev":
"b95ce72dc081549b258f2836aaf85c1c95b2356a"}

[commit-bot: I haz the power, 2017-05-11 02:11:45]

Description was changed from

==========
Image Capture Android: make torch mode override other fill light mode(s)

Setting the torch (flash constantly on) should override other fill light
mode settings (i.e. off/auto/always).  This CL fixes that for both the
old and new API. Also, for the new API, torch needs the CONTROL_AE_MODE 
specified.

(This CL does not fix the auto/always flash not working properly in 
the new API because this needs a dance of CONTROL_AE_PRECAPTURE_TRIGGER 
manipulation worth a CL of its own).

BUG=720250
==========

to

==========
Image Capture Android: make torch mode override other fill light mode(s)

Setting the torch (flash constantly on) should override other fill light
mode settings (i.e. off/auto/always).  This CL fixes that for both the
old and new API. Also, for the new API, torch needs the CONTROL_AE_MODE 
specified.

(This CL does not fix the auto/always flash not working properly in 
the new API because this needs a dance of CONTROL_AE_PRECAPTURE_TRIGGER 
manipulation worth a CL of its own).

BUG=720250

Review-Url: https://codereview.chromium.org/2873843004
Cr-Commit-Position: refs/heads/master@{#470774}
Committed:
https://chromium.googlesource.com/chromium/src/+/b95ce72dc081549b258f2836aaf8...
==========

[commit-bot: I haz the power, 2017-05-11 02:11:46]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b95ce72dc081549b258f2836aaf8...